Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

printer.print_run_result_error should log to warning or error instead of info #1818

Closed
heisencoder opened this issue Oct 9, 2019 · 3 comments
Closed

printer.print_run_result_error should log to warning or error instead of info #1818

heisencoder opened this issue Oct 9, 2019 · 3 comments
Labels
bug Something isn't working good_first_issue Straightforward + self-contained changes, good for new contributors!
Milestone
Louisa May Alcott

Comments

@heisencoder
Copy link
Contributor

dbt.ui.printer.print_run_result_error only uses logger.info to display the messages. However, these should be logged at either the error or warning level depending on the is_warning parameter.
@heisencoder heisencoder added bug Something isn't working triage labels Oct 9, 2019
@drewbanin drewbanin added good_first_issue Straightforward + self-contained changes, good for new contributors! and removed triage labels Oct 10, 2019
@drewbanin
Copy link
Contributor

Hey @heisencoder - I buy that! Feel free to send through a PR for the change if you're so inclined; I'd happily merge it :)

@heisencoder
Copy link
Contributor Author

Coming shortly...

@heisencoder heisencoder mentioned this issue Oct 10, 2019
Merged
@drewbanin drewbanin added this to the Louisa May Alcott milestone Oct 11, 2019
@drewbanin
Copy link
Contributor

this was fixed in #1823 - thanks @heisencoder! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good_first_issue Straightforward + self-contained changes, good for new contributors!
Projects
None yet
Milestone
Louisa May Alcott
Development

No branches or pull requests
2 participants
@heisencoder @drewbanin