Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snowflake integration test 050: alternate warehouse (DBT_TEST_ALT) should be configurable #1939

Closed
clausherther opened this issue Nov 19, 2019 · 1 comment · Fixed by #1979
Closed

Snowflake integration test 050: alternate warehouse (DBT_TEST_ALT) should be configurable #1939

clausherther opened this issue Nov 19, 2019 · 1 comment · Fixed by #1979
Labels
bug Something isn't working repo ci/cd Testing and continuous integration for dbt-core + adapter plugins
Milestone
0.15.1

Comments

@clausherther
Copy link
Contributor

When running integration test, test/integration/050_warehouse_test/test_warehouses.py::TestModelWarehouse::test_snowflake_override_ok
dbt uses a hardcoded warehouse name DBT_TEST_ALT for the alternate virtual warehouse.
https://github.com/fishtown-analytics/dbt/blob/099adf9bab908d62e9f07eadb5033051c5c33575/test/integration/050_warehouse_test/test_warehouses.py#L42

This should be configurable in test.env, e.g.

SNOWFLAKE_TEST_ALT_WAREHOUSE=MY_ALT_WH
@clausherther clausherther added bug Something isn't working triage labels Nov 19, 2019
@clausherther clausherther changed the title DBT_TEST_ALT should be configurable Snowflake integration test 050: alternate warehouse (DBT_TEST_ALT) should be configurable Nov 19, 2019
@drewbanin drewbanin added automated testing bug Something isn't working and removed bug Something isn't working triage labels Nov 26, 2019
@drewbanin drewbanin added this to the 0.15.1 milestone Nov 26, 2019
@drewbanin
Copy link
Contributor

Thanks for the report @clausherther - agreed! We'll fix this in a future release

@beckjake beckjake mentioned this issue Dec 4, 2019
Merged
beckjake added a commit that referenced this issue Dec 5, 2019
@beckjake
Merge pull request #1979 from fishtown-analytics/feature/configurable…
549168b 
…-test-warehouses

make tests honor environment variables (#1939)
@jtcohen6 jtcohen6 added repo ci/cd Testing and continuous integration for dbt-core + adapter plugins and removed automated testing labels Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working repo ci/cd Testing and continuous integration for dbt-core + adapter plugins
Projects
None yet
Milestone
0.15.1
Development

Successfully merging a pull request may close this issue.

make tests honor environment variables (#1939) dbt-labs/dbt-core
3 participants
@drewbanin @clausherther @jtcohen6