Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add newline around SQL in incremental materialization to guard against line comments. #1019

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Add newline around SQL in incremental materialization to guard against line comments. #1019

merged 1 commit into from
Sep 20, 2018

Conversation

elexisvenator
Copy link
Contributor

Prevents syntax errors when the last line of a model is a line comment.

@drewbanin drewbanin self-requested a review September 20, 2018 12:19
@drewbanin
Copy link
Contributor

Thanks @elexisvenator! This PR fixes #1018

@drewbanin drewbanin changed the base branch from master to dev/guion-bluford September 20, 2018 12:21
@drewbanin drewbanin merged commit 5b94bc3 into dbt-labs:dev/guion-bluford Sep 20, 2018
@drewbanin drewbanin mentioned this pull request Sep 20, 2018
Closed
@drewbanin drewbanin mentioned this pull request Oct 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin Awaiting requested review from drewbanin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elexisvenator @drewbanin