[Stephen Girard] handle unexpected max_loaded_at types #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
changed the title
drewbanin
changed the title
beckjake
reviewed
Mar 4, 2019
core/dbt/adapters/base/impl.py
Outdated
| @@ -79,6 +79,26 @@ def _utc(dt): | |||
| return dt.replace(tzinfo=pytz.UTC) | |||
|
|
|||
|
|
|||
| def _parse_max_loaded_at(row, source, field_name): | |||
| for dt in row: | |||
| if dt is None: | |||
There was a problem hiding this comment.
I think this logic just belongs in _utc itself.
beckjake
approved these changes
Mar 5, 2019
…t into fix/handle-unexpected-snapshot-values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some light error handling. Previously, values like
Noneanddatetime.dates would fail with confusing references to... has no attribute tzinfo.