remove non-destructive mode (#1415) #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
force-pushed
the
feature/destroy-non-destructive
branch
from
39eef1d
to
7b2ac50
Compare
beckjake
force-pushed
the
feature/destroy-non-destructive
branch
from
7b2ac50
to
1205e15
Compare
drewbanin
approved these changes
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1415
Remove all uses of and references to the
--non-destructiveflag. This will conflict with #1416 but I figured I'd keep them separate. I'll resolve the conflicts once I merge one of them.I didn't see any use of this flag in dbt-spark or dbt-presto.