Handle seeds with utf-8 BOM (#1177) #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 9, 2019 17:56
Fixes some neat windows behavior where the default code page can be cp1252 Add BOM unit test
beckjake
force-pushed
the
feature/strip-seed-bom
branch
from
5803728
to
d74e37d
Compare
cmcarthur
reviewed
May 10, 2019
core/dbt/clients/agate_helper.py
Outdated
| @@ -41,4 +42,7 @@ def as_matrix(table): | |||
|
|
|||
|
|
|||
| def from_csv(abspath): | |||
| return agate.Table.from_csv(abspath, column_types=DEFAULT_TYPE_TESTER) | |||
| with dbt.compat.open_file(abspath) as fp: | |||
| if fp.read(1) != u'\ufeff': | |||
There was a problem hiding this comment.
did you try using codecs.BOM_UTF8 instead of the hardcoded value here?
https://docs.python.org/2/library/codecs.html#codecs.BOM_UTF8
https://docs.python.org/3/library/codecs.html#codecs.BOM_UTF8
There was a problem hiding this comment.
I'm explicitly opening the value as unicode (that's what open_file does), so examining the unicode code point rather than the byte sequence is correct.
There was a problem hiding this comment.
Not suggesting that your comparison is wrong, just that you could replace the magic value u'\ufeff' with codecs.BOM_UTF8.decode('utf-8')
cmcarthur
approved these changes
May 10, 2019
This was referenced Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1177
Instead of passing agate a filepath, open the file at that path, look at the first byte, and seek back if it's not a BOM. Regardless, pass the file handle to agate instead.
That way when agate gets the file handle, if there is a BOM, it won't see it.