Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require versions in package defs (#1546) #1551

Merged
merged 2 commits into from
Jun 18, 2019

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Jun 18, 2019

Fixed #1546

seems better?:

$ dbt deps
Running with dbt=0.14.0-a1
Encountered an error:
package dependency fishtown-analytics/dbt_utils is missing a "version" field

@drewbanin
Copy link
Contributor

@beckjake is there any way for us to give this error message some love? It's actually less clear from this output that the issue is a missing version. At least KeyError: version showed the missing key :)

@beckjake
Copy link
Contributor Author

I mean, we can remove it from required and manually change it, but jsonschema kind of sucks here. There's only one valid schema!

@beckjake beckjake force-pushed the fix/package-without-version branch from 59590ca to 927c374 Compare June 18, 2019 18:42
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- approved!

@beckjake beckjake merged commit f95c712 into dev/wilt-chamberlain Jun 18, 2019
@beckjake beckjake deleted the fix/package-without-version branch June 18, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using the package syntax without version, dbt returns a vague error message
2 participants