Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExternalTable relation type, update Snowflake adapter (issue #1505) #1571

Merged

Conversation

josegalarza
Copy link
Contributor

Why?
Snowflake EXTERNAL TABLE is not a valid RelationType in dbt.

What's new?

  • Added ExternalTable relation type .
  • Updated Snowflake adapter.

Notes

@krishbox
Copy link

Hi @drewbanin, is there anything we can do or need to do to pass the test that failed in the CI checks?

@drewbanin
Copy link
Contributor

Hey - I tried kicking these tests off last night, but looks like something funky happened. Running them again now :)

@beckjake
Copy link
Contributor

Since github (or azure?) doesn't update these things, here's the soon-to-be-passing link to the azure piplines job: https://dev.azure.com/fishtown-analytics/dbt/_build/results?buildId=288

Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drewbanin
Copy link
Contributor

Thanks @josegalarza - we'll sneak this one in for our 0.14.0 release!

@drewbanin drewbanin merged commit fdcb395 into dbt-labs:dev/wilt-chamberlain Jun 26, 2019
@krishbox
Copy link

Yay! Thank you @drewbanin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants