(#1687) no-op column expansion on Snowflake + BQ #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcarthur
requested changes
Aug 19, 2019
There was a problem hiding this comment.
@drewbanin the tests around column expansion failed.
Completed with 1 error and 0 warnings:
Database Error in model incremental (models/incremental.sql)
100078 (22000): 018e4fb1-038b-d1a1-0000-0e690337521a: String 'Amerisource Bergen' is too long and would be truncated
compiled SQL at target/compiled/test/incremental.sql
|
@cmcarthur turns out column expansion is still necessary on Snowflake, but we can use an |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1687
Fully no-op column expansion on Snowflake (and avoid running introspective queries on BigQuery) - these databases do not require column expansion because of their intelligent string types.