Add runtime per-model warehouse config on snowflake models (#1358) #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
force-pushed
the
feature/warehouse-model-config
branch
3 times, most recently
from
0f9eb1d
to
6748057
Compare
Add warehouse config to snowflake Add concept of adapter-level pre/post model hooks Use those hooks to optionally set a warehouse on a per-model basis Added some integration tests - one tests that the warehouse is applied by setting a bad one and failing - one that tests that overriding the warehouse to a good one is ok
beckjake
force-pushed
the
feature/warehouse-model-config
branch
from
6748057
to
a227b31
Compare
drewbanin
reviewed
Sep 27, 2019
| logging.getLogger('requests').setLevel(logging.ERROR) | ||
| logging.getLogger('urllib3').setLevel(logging.ERROR) | ||
| logging.getLogger('google').setLevel(logging.ERROR) | ||
| logging.getLogger('snowflake.connector').setLevel(logging.ERROR) |
drewbanin
approved these changes
Sep 27, 2019
| warehouse = config.get('warehouse', default_warehouse) | ||
| if warehouse == default_warehouse or warehouse is None: | ||
| return None | ||
| previous = self._get_warehouse() |
There was a problem hiding this comment.
i like that this cost is only incurred if a non-default warehouse is specified!
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1358