Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonschema+deps fixes #1821

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Conversation

beckjake
Copy link
Contributor

Fix #1817

Fix the offending regex to use js-compatible syntax
Fix the werkzeug pin to be much more friendly - it was set to a (valid!) value I was using for testing.
Pin hologram to 0.0.4, which pins all its dependencies
Pin dataclasses out of an excess of caution

Fix the offending regex to use js-compatible syntax
Fix the werkzeug pin
Pin hologram to 0.0.4
Pin dataclasses out of an excess of caution
@cla-bot cla-bot bot added the cla:yes label Oct 10, 2019
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when the tests pass!

@beckjake beckjake merged commit 2815b33 into dev/louisa-may-alcott Oct 10, 2019
@beckjake beckjake deleted the fix/json-compatible-regexes branch October 10, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set upper bound on jsonschema dep
2 participants