bugfix: respect config options in dbt_project.yml #255
+140
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 23, 2016 09:12
…bugfix/respect-config-options
|
Fixes #254 |
drewbanin
approved these changes
Dec 24, 2016
|
|
||
| def read_config(profiles_dir=None): | ||
| if profiles_dir is None: | ||
| profiles_dir = default_profiles_dir |
There was a problem hiding this comment.
where does default_profiles_dir come from?
|
|
||
| def test__explicit_opt_out(self): | ||
| self.set_up_config_options(send_anonymous_usage_stats=False) | ||
| self.assertFalse(dbt.config.send_anonymous_usage_stats(TMPDIR)) |
|
back atcha @drewbanin |
drewbanin
reviewed
Dec 24, 2016
| @@ -5,9 +5,6 @@ | |||
|
|
|||
|
|
|||
| def read_config(profiles_dir=None): | |||
| if profiles_dir is None: | |||
| profiles_dir = default_profiles_dir | |||
|
|
|||
| path = os.path.join(profiles_dir, 'profiles.yml') | |||
There was a problem hiding this comment.
I think passing None to os.path.join causes a TypeError.
Previously, this file was assumed to be located at ~/.dbt/profiles.yml. We should either remove the default value for profiles_dir and insist that the caller passes a value, or we should coalesce None to the default filepath
There was a problem hiding this comment.
this is a good call. since read_config is part of the private API of this namespace, and calls have to go through send_anonymous_usage_stats, i just removed the default None value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respect config options in dbt_project.yml
Factor out code related to global configuration. Also makes
send_anonymous_usage_statsconfig option work.