add parser #292
add parser #292
Conversation
dbt/compilation.py
Outdated
| model for model in all_models | ||
| if model.is_enabled and not model.is_empty | ||
| model for model in parsed_models | ||
| if model.get('enabled') == True and model.get('empty') == True |
There was a problem hiding this comment.
we probably want empty = False here, right?
dbt/parser.py
Outdated
| env = jinja2.sandbox.SandboxedEnvironment( | ||
| undefined=SilentUndefined) | ||
|
|
||
| env.from_string(model.get('raw_sql')).render(context) |
|
|
||
| filepath = os.path.join(root, model.rel_filepath) | ||
| logger.info("Compiler error in {}".format(filepath)) | ||
| logger.info("Compiler error in {}".format(model.get('path'))) |
dbt/compilation.py
Outdated
| for name, injected_model in injected_models.items(): | ||
| # now turn a model back into the old-style model object | ||
| model = Model( | ||
| self.project, |
There was a problem hiding this comment.
do we always want self.project here?
| profile = self.project.run_environment() | ||
| compiled_model.compile(context, profile, self.existing_models) | ||
| compiled_models.append(compiled_model) | ||
| post_filter = [ |
There was a problem hiding this comment.
i think this is complex enough that it warrants a for loop!
| "{{ col.name }}" {% if not loop.last %},{% endif %} | ||
| {% endfor %}, | ||
| {% endraw %} | ||
| {% for col in get_columns_in_table(source_schema, source_table) %} |
| @@ -291,7 +291,7 @@ def rename(cls, profile, from_name, to_name, model_name=None): | |||
|
|
|||
| @classmethod | |||
| def execute_model(cls, profile, model): | |||
| parts = re.split(r'-- (DBT_OPERATION .*)', model.compiled_contents) | |||
| parts = re.split(r'-- (DBT_OPERATION .*)', model.get('wrapped_sql')) | |||
There was a problem hiding this comment.
we'll be able to replace this with separate nodes grouped into a transaction, right?
dbt/compilation.py
Outdated
| logger.info("Enabled models:") | ||
| for m in all_models: | ||
| logger.info(" - {}".format(".".join(m.fqn))) | ||
| for n,m in all_models.items(): |
There was a problem hiding this comment.
for m in all_models.values() :)
| context['config'] = self.__model_config(model, linker) | ||
| context['this'] = This( | ||
| context['env']['schema'], | ||
| (model.get('name') if dbt.flags.NON_DESTRUCTIVE |
There was a problem hiding this comment.
this is ported from model.tmp_name(), right? it took me a minute to work out what was happening here... maybe we could add a comment like:
for non-destructive runs,
thisshould return the final name of the model, because we're truncating and inserting instead dropping and re-creating.
dbt/compilation.py
Outdated
| self.project_schemas | ||
| ) | ||
| elif injected_node.get('resource_type') == NodeType.Archive: | ||
| # unfortunately we do everything automagically for |
dbt/graph/selector.py
Outdated
| @@ -112,9 +121,21 @@ def get_nodes_from_spec(project, graph, spec): | |||
| if select_children: | |||
| for node in selected_nodes: | |||
| child_nodes = nx.descendants(graph, node) | |||
| print('\nchild_nodes') | |||
dbt/runner.py
Outdated
|
|
||
| rows = cursor.fetchall() | ||
|
|
||
| adapter.rollback(profile) |
dbt/runner.py
Outdated
| output = ("START archive table {schema}.{model_name} " | ||
| .format(**print_vars)) | ||
| return output | ||
| print('hooks') |
| output = "{info} table {schema}.{model_name} ".format(**print_vars) | ||
| return output | ||
| compiled_hooks = [ | ||
| dbt.compilation.compile_string(hook, ctx) for hook in hooks |
There was a problem hiding this comment.
hooks should also have access to their model context, eg. this or var. Does that happen here?
There was a problem hiding this comment.
@cmcarthur excited to get this merged. Some comments for my edification, but otherwise lgtm
| @@ -0,0 +1,45 @@ | |||
| import codecs | |||
| @@ -182,7 +182,7 @@ def rename(cls, profile, from_name, to_name, model_name=None): | |||
|
|
|||
| @classmethod | |||
| def execute_model(cls, profile, model): | |||
| parts = re.split(r'-- (DBT_OPERATION .*)', model.compiled_contents) | |||
| parts = re.split(r'-- (DBT_OPERATION .*)', model.get('wrapped_sql')) | |||
There was a problem hiding this comment.
we'll break these out into separate nodes in a future PR, yeah?
No description provided.