Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some nice utility functions for compilation, and use them #309

Merged
merged 3 commits into from
Mar 3, 2017

Conversation

cmcarthur
Copy link
Member

@cmcarthur cmcarthur commented Mar 3, 2017

Makes things a little easier to read.

Performs all compilation in a Jinja SandboxedEnvironment. Only builds that environment once.

@cmcarthur cmcarthur requested a review from drewbanin March 3, 2017 16:59
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so good! love that all the jinja error handling is in one place now

if target_model.get('config', {}) \
.get('materialized') == 'ephemeral':

if get_materialization(target_model) == 'ephemeral':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing

@cmcarthur cmcarthur merged commit 90836d6 into development Mar 3, 2017
cmcarthur added a commit that referenced this pull request Mar 3, 2017
@cmcarthur cmcarthur deleted the refactor/jinja-and-exceptions branch September 7, 2018 15:51
yu-iskw pushed a commit to yu-iskw/dbt that referenced this pull request Aug 17, 2021
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
automatic commit by git-black, original commits:
  1a101ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants