add macros to flat graph #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
reviewed
Mar 15, 2017
dbt/compilation.py
Outdated
| name = macro.get('name') | ||
| package_name = macro.get('package_name') | ||
|
|
||
| if context.get(package_name, {}).get(name) is not None: |
There was a problem hiding this comment.
we parse each macro once, but parsing a "macro" is really parsing the file that macro is in. so, without this code, if a file contained 3 macros, we'd parse that file 3 times.
| @@ -425,16 +439,7 @@ def compile_nodes(self, linker, nodes, macro_generator): | |||
| if cycle: | |||
| raise RuntimeError("Found a cycle: {}".format(cycle)) | |||
|
|
|||
| return wrapped_nodes, written_nodes | |||
|
|
|||
| def generate_macros(self, all_macros): | |||
dbt/compilation.py
Outdated
|
|
||
| compiled_nodes, written_nodes = self.compile_nodes(linker, all_nodes, | ||
| macro_generator) | ||
| compiled_graph, written_nodes = self.compile_graph(linker, flat_graph) | ||
|
|
||
| self.write_graph_file(linker) | ||
|
|
||
| stats = {} |
There was a problem hiding this comment.
we can use a defaultdict here :)
stats = defaultdict(int)
stats[node.get('resource_type')] += 1
... just sayin
dbt/parser.py
Outdated
| return to_return | ||
|
|
||
|
|
||
| class FakeProject: |
drewbanin
approved these changes
Mar 15, 2017
| @@ -30,6 +29,45 @@ | |||
| graph_file_name = 'graph.gpickle' | |||
|
|
|||
|
|
|||
| def recursively_parse_macros_for_node(node, flat_graph, context): | |||
| # this once worked, but is now long dead | |||
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
automatic commit by git-black, original commits: de06d65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.