Wrap redshift DROP ... CASCADE in a lock #349
Merged
+175
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
approved these changes
Mar 25, 2017
| from dbt.adapters.postgres import PostgresAdapter | ||
| from dbt.logger import GLOBAL_LOGGER as logger # noqa | ||
|
|
||
|
|
||
| drop_lock = multiprocessing.Lock() |
There was a problem hiding this comment.
should we pop before we lock & drop it?
There was a problem hiding this comment.
it took a lot of effort not to make this pop_lock_and_drop
drewbanin
changed the title
yu-iskw
pushed a commit
to yu-iskw/dbt
that referenced
this pull request
Aug 17, 2021
* Tidy up changelog * Add 0.7.0 entry to changelog * Add order_by argument to get_column_values (dbt-labs#349) * Add slugify macro to utils, use in pivot macro (dbt-labs#314) * 0.20.0 compatibility (dbt-labs#371) * Explicitly redefine Redshift -> default * Upgrade generic tests * Rm namespaces macro. New dispatch syntax * Run tests with 0.20.0rc1 * Update changelog, readme Co-authored-by: Jeremy Cohen <[email protected]> * Simplify concat (dbt-labs#373) * Postgres also have an alternative concat binary operation (dbt-labs#296) * Update default implementation of concat macro Co-authored-by: Christophe Duong <[email protected]> Co-authored-by: Jeremy Cohen <[email protected]> Co-authored-by: Christophe Duong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a test Redshift cluster and ran the new test against development. Got a conflict with concurrent transaction every single time.
On this branch, the error isn't happening anymore.