Handle external bigquery relations (#791) #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
commented
Jul 6, 2018
dbt/logger.py
Outdated
| @@ -1,5 +1,6 @@ | |||
| import dbt.compat | |||
| import logging | |||
| import logging.handlers | |||
There was a problem hiding this comment.
It took me a while to figure out why this is failing intermittently for me - it's because in normal operation something else imports logging.handlers and modules are singletons so everyone accessing logging has access to logging.handlers once it's been imported.
However, in some test runs for whatever reason, dbt.logger.initialize_logger executes before whatever other module that's loading does import logging.handlers, and so it doesn't see logging.handlers and fails.
cmcarthur
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to the BigQuery adapter for the presence of
externaldata sources, fixing #791