Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigquery fix concurrent relation loads #835

Merged
merged 10 commits into from
Jul 13, 2018

Conversation

cmcarthur
Copy link
Member

Reopened from #834 -- a branch named bigquery already exists, so any branch named bigquery/* does not work

Fix for #726

@drewbanin rather than switching this to use get_relation, i fixed list_relation by making it more atomic (it doesn't paginate at all now). I think there's a case to be made for changing this materialization to use get_relation directly instead, but this keeps the abstraction in place and makes the code work.

@drewbanin
Copy link
Contributor

drewbanin commented Jul 9, 2018

@cmcarthur this looks reasonable to me! :shipit:

@cmcarthur cmcarthur merged commit 376709c into development Jul 13, 2018
@cmcarthur cmcarthur deleted the bigquery-fix-concurrent-relation-loads branch July 13, 2018 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants