Add bigquery hooks (#779) #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s 'create dataset'
drewbanin
requested changes
Jul 11, 2018
| 'models': {}, | ||
| 'seeds': { | ||
| 'post-hook': [ | ||
| 'alter table {{ this }} add column new_col int', |
There was a problem hiding this comment.
does this work? alter table ... add column is not supported on BigQuery! I think a better test might just update a column or insert a record
There was a problem hiding this comment.
It turns out that we weren't loading the seed file on Postgres or BigQuery because the extension is .sql instead of .csv, so these hooks never run and the tests always pass.
Good stuff.
drewbanin
approved these changes
Jul 13, 2018
|
@drewbanin Per our in-person/slack discussion, fixed the hook + seed issues you found and added tests. Let me know when you've tested this out and if it's good to go I'll merge it |
|
@beckjake just gave this a spin locally and it works great! Feel free to merge when the tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pre/post hook support for bigquery (fixes #779).