Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

let the empty string mean null (#993) #995

Merged
merged 1 commit into from
Sep 12, 2018
Merged

let the empty string mean null (#993) #995

merged 1 commit into from
Sep 12, 2018

Conversation

beckjake
Copy link
Contributor

When dbt encounters the empty string in a csv, treat it as NULL instead of ''.

Fixes #993

@drewbanin drewbanin mentioned this pull request Sep 12, 2018
Closed
drewbanin
drewbanin approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@beckjake beckjake merged commit d66f3a8 into dev/lucretia-mott Sep 12, 2018
@beckjake beckjake deleted the fix/agate-empty-string-nulls branch September 12, 2018 13:24
@beckjake beckjake mentioned this pull request Sep 12, 2018
Closed
@griveral
Copy link

I noticed that in seed in snowflake, the empty string will be converted to string NULL and not SQL NULL. Is there a way that I want SQL NULL to be seeded and not STRING NULL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beckjake @griveral @drewbanin