Fix QUOTED_IDENTIFIERS_IGNORE_CASE errors (#982) #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
force-pushed
the
fix/snowflake-quoted-identifiers-case-docs
branch
from
7f13a25
to
260572e
Compare
cmcarthur
approved these changes
Sep 12, 2018
| 'QUOTED_IDENTIFIERS_IGNORE_CASE':True | ||
| } | ||
| return old_connect(*args, **kwargs) | ||
| with patch.object(snowflake_impl.snowflake.connector, 'connect', connect): |
drewbanin
approved these changes
Sep 12, 2018
beckjake
force-pushed
the
fix/snowflake-quoted-identifiers-case-docs
branch
from
260572e
to
40f009f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When QUOTED_IDENTIFIERS_IGNORE_CASE is set, avoid causing errors in the catalog. Add a test for the same. Fixes #982.
PR #992 masked this issue, in a bad, potentially silently-dropping-data way, so I also had to add an exception that re-exposes it.