Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from quickcheck to cargo-fuzz #167

Open
zetanumbers opened this issue Jun 27, 2022 · 4 comments
Open

Switch from quickcheck to cargo-fuzz #167

zetanumbers opened this issue Jun 27, 2022 · 4 comments

Comments

@zetanumbers
Copy link
Contributor

quickcheck tests are super long for miri (14m24s enabled vs. 1m48s disabled). Perhaps it is better to separate "try to break the program by massaging input for a while" tests and usual tests? cargo-fuzz defines fuzz targets, which already are separate from tests.
@fitzgen
Copy link
Owner

fitzgen commented Jun 27, 2022

Happy to receive a PR doing this.

@fitzgen
Copy link
Owner

fitzgen commented Jun 27, 2022

Would need to run each of the fuzz targets on CI (in separate jobs so we get parallelism) for ~5 minutes as well.

@zetanumbers
Copy link
Contributor Author

For now i made it possible to not enable quickcheck via similarly named feature in #168.

@zetanumbers
Copy link
Contributor Author

I think it could be better to not switch to cargo-fuzz if we would run 1 test in quickcheck. This would allow to check UB in the quickcheck! code. However it would be desirable to write some predefined values to increase code coverage and for determinism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fitzgen @zetanumbers