Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anything to do before making a new breaking release? #51

Closed
3 tasks
fitzgen opened this issue Nov 22, 2019 · 4 comments
Closed
3 tasks

Anything to do before making a new breaking release? #51

fitzgen opened this issue Nov 22, 2019 · 4 comments

Comments

@fitzgen
Copy link
Owner

fitzgen commented Nov 22, 2019

We have had a bunch of great work committed to master that I'd like to publish, and some of it is breaking (the reversal of bump direction, for example). Because it is breaking, I'd like to double check that we aren't missing any breaking changes that we can coalesce into a single release, rather than eventually doing multiple breaking releases.

@TethysSvensson, anything else on your radar? Anything else needed for your flatbuffers effort?

cc @vorner


TODO

  • Fill out the CHANGELOG
  • Explain how to update for the breaking changes
  • other stuff?

Commits since the last release
@TethysSvensson
Copy link
Contributor

I think we should consider whether this is the right time to remove deprecated stuff. The things I know of are:

  • The std feature flag, which no longer does anything
  • The function each_allocated_chunk

Otherwise I think this would be a really nice time to do a new release, and I cannot think of any important improvements right now.

I can think of a few non-important ones improvements, that I might be interested in exploring at some point, but even then I do not think any of them would break backwards compatibility.

  • I think we could potentially improve the strategy for how to increase the chunk size -- that is if somebody is willing to benchmarks/code dives to figure out what is "best".
  • I think it would be interesting to explore an API for using bumpalo without depending on alloc for e.g. tiny embedded applications. I am thinking it might be possible to have an initializer which simply contains a &mut [u8] internally without having a huge amount of code duplication.

I do not have any current needs for any of them though, so I think it is unlikely that I will get around to exploring them in the near future (or ever).

@TethysSvensson
Copy link
Contributor

Also, do you think that #2 and #12 should somehow be resolved before you to a release? Or do you just want to keep them open for now?

@TethysSvensson
Copy link
Contributor

@fitzgen Are you still planning on doing a release soon?

@fitzgen
Copy link
Owner Author

fitzgen commented Dec 20, 2019

Yeah, sorry been a bit busy and travelling a bunch.

@fitzgen fitzgen closed this as completed Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants