Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --add-opens JVM option #48

Open
asm0dey opened this issue Apr 2, 2021 · 3 comments
Open

Add support for --add-opens JVM option #48

asm0dey opened this issue Apr 2, 2021 · 3 comments

Comments

@asm0dey
Copy link

asm0dey commented Apr 2, 2021

Starting from JDK 9 we may need to add option --add-opens to the application, but if user has JDK 8 installed it won't launch because JDK 8 is not aware of such option.

@jjlauer
Copy link
Member

jjlauer commented Apr 2, 2021

@asm0dey I would entertain any pull requests on this, although there isn't any support for conditional logic on JVM arguments supplied depending on the JVM that's going to execute at runtime. You can easily supply this as a hard-coded JVM argument, but not conditionally. I think it'd be fairly interesting to support that concept if you were interested in possibly trying to implement it.

@asm0dey
Copy link
Author

asm0dey commented Apr 3, 2021

Well, if I understand correctly we have a function to get a version of Java. If so — then before building final command we could add one more arg, which will be assigned in the if block

@asm0dey
Copy link
Author

asm0dey commented Apr 3, 2021

Like

[ parseJavaMajorVersion ${getJavaVersion $java_bin} -ge 9 ] && JAVA_ADD_OPENS=openshere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants