Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Not fail if no response was received #12

Closed
marcauberer opened this issue Jul 30, 2020 · 6 comments · Fixed by #13
Closed

Feature request: Not fail if no response was received #12

marcauberer opened this issue Jul 30, 2020 · 6 comments · Fixed by #13
Assignees
Labels
enhancement New feature or request

Comments

@marcauberer
Copy link

Hi,
I have a feature request:
Wouldn't it be nice to have a option to disable build failure, when no response, but a HTTP 200 status code was received as answer? Such as disableFailureOnNoResponse = true / false?

@fjogeleit
Copy link
Owner

fjogeleit commented Jul 30, 2020

Hey, for sure. I will have a look on it.

So you receive a Status Code of 200 but the Body of the response is empty?

@fjogeleit
Copy link
Owner

Could you provide your received error message? In regular cases it should already work with success status code and no response body.

@marcauberer
Copy link
Author

Run fjogeleit/http-request-action@master
  with:
    url: https://www.chillibits.com/src/build.php
    method: GET
    contentType: application/json
    data: {}
    timeout: 5000
##[error]{"error":"no response received"}

@fjogeleit fjogeleit self-assigned this Jul 30, 2020
@fjogeleit fjogeleit added the enhancement New feature or request label Jul 30, 2020
@fjogeleit fjogeleit linked a pull request Jul 30, 2020 that will close this issue
@fjogeleit
Copy link
Owner

You can try it out with the new Release v1.4.0. See the readme or release notes for details

https://github.com/fjogeleit/http-request-action/releases/tag/v1.4.0

@fjogeleit
Copy link
Owner

In many cases this error happens because of missing or incomplete response header. So the Action will show you a warning with the returned error but it will no longer fail with this new option

@marcauberer
Copy link
Author

Thanks a lot! I will try it when I push the next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants