Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Reconciliation Loop #1364

Open
mtolan opened this issue Oct 29, 2020 · 5 comments
Open

Global Reconciliation Loop #1364

mtolan opened this issue Oct 29, 2020 · 5 comments
Labels

Comments

@mtolan
Copy link

mtolan commented Oct 29, 2020

I've been experiencing the situation where transient failures occur in https://github.com/coreos/flannel/blob/master/backend/vxlan/vxlan_network.go#L145 especially under heavy memory contention. The current code structure in vxlan_network does not include a facility for retries, which results in the newly observed subnet never being properly added to netlink, which gives rise to #958

After discussions in the 10/29/2020 community meeting, Rajat proposed that rather than add retries to the code within vxlan_network.go that we would want to move to an architecture with a global reconciliation loop, to be run on some configurable interval, that would compare the etcd or k8s contents with the current set of iptables rules and make any required changes. This would help in reducing or eliminating all persistent error conditions, not just the one underlying 958.

@mtolan
Copy link
Author

mtolan commented Oct 29, 2020

Apologies that this is pretty light on expected behavior and architecture. My golang knowledge is still a bit rudimentary, and I wouldn't presume to suggest where the most central changes should occur.

@stale
Copy link

stale bot commented Jan 25, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 25, 2023
@rbrtbnfgl
Copy link
Contributor

This is related to #958

@stale stale bot removed the wontfix label Jan 26, 2023
@stale
Copy link

stale bot commented Jul 25, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 25, 2023
@thomasferrandiz thomasferrandiz pinned this issue Jul 26, 2023
@stale stale bot removed the wontfix label Jul 26, 2023
@manuelbuil manuelbuil unpinned this issue Aug 17, 2023
Copy link

stale bot commented Jan 23, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 23, 2024
@thomasferrandiz thomasferrandiz pinned this issue Jan 23, 2024
@stale stale bot closed this as completed Feb 13, 2024
@stale stale bot removed the wontfix label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants