From 178e1a415270932ae0c96dfd2bae13da5c9b81d0 Mon Sep 17 00:00:00 2001 From: Flarnie Marchan Date: Thu, 20 Jul 2017 13:02:26 -0700 Subject: [PATCH] Remove expando that we were adding to portal container **what is the change?:** see title **why make this change?:** this is part of an old approach to detecting portals, and we have instead added a check in the `findHostInstance` method to filter out portals. **test plan:** `yarn test` **issue:** https://github.com/facebook/react/issues/8854 --- src/renderers/shared/fiber/ReactFiberCommitWork.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/renderers/shared/fiber/ReactFiberCommitWork.js b/src/renderers/shared/fiber/ReactFiberCommitWork.js index 02a8f59e6de98..23a0230e06541 100644 --- a/src/renderers/shared/fiber/ReactFiberCommitWork.js +++ b/src/renderers/shared/fiber/ReactFiberCommitWork.js @@ -218,10 +218,6 @@ module.exports = function( } } else { if (isContainer) { - if (parentFiber.tag === HostPortal) { - // allows us to identify the portal container in other places - parent.__reactInternalIsPortalContainer = true; - } appendChildToContainer(parent, node.stateNode); } else { appendChild(parent, node.stateNode);