Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted semicolon in assets files #2120

Closed
clarkwinkelmann opened this issue Apr 11, 2020 · 3 comments · Fixed by #2280
Closed

Unwanted semicolon in assets files #2120

clarkwinkelmann opened this issue Apr 11, 2020 · 3 comments · Fixed by #2280

Comments

@clarkwinkelmann
Copy link
Member

clarkwinkelmann commented Apr 11, 2020

Bug Report

Current Behavior
There is a mysterious semi column added underneath each extension javascript by the JsCompiler and I can't find if there's any real reason for it to be there. It's presence is not creating any problem, but it's disturbing for hackers reading the file 😛

Steps to Reproduce

  1. Enable any extension
  2. Open /assets/forum-<hash>.js or /assets/admin-<hash>.js
  3. Observe the semi column (;) on its own line underneath each extension.
  4. Those semi-columns are not part of the extension source code

For example:

This is only part of the assets file. We can see the semi column on lines 6 and 13 of this code:

flarum.extensions['fof-ban-ips']=module.exports;

var module={};

module.exports=function(e){var t={};function s(r){if(t[r])return t[r].exports;var a=t[r]={i:r,l:!1,exports:{}};return e[r].call(a.exports,a,a.exports,s),a.l=!0,a.exports}return s.m=e,s.c=t,s.d=function(e,t,r){s.o(e,t)||Object.defineProperty(e,t,{enumerable:!0,get:r})},s.r=function(e){"undefined"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(e,Symbol.toStringTag,{value:"Module"}),Object.defineProperty(e,"__esModule",{value:!0})},s.t=function(e,t){if(1&t&&(e=s(e)),8&t)return e;if(4&t&&"object"==typeof e&&e&&e.__esModule)return e;var r=Object.create(null);if(s.r(r),Object.defineProperty(r,"default",{enumerable:!0,value:e}),2&t&&"string"!=typeof e)for(var a in e)s.d(r,a,function(t){return e[t]}.bind(null,a));return r},s.n=function(e){var t=e&&e.__esModule?function(){return e.default}:function(){return e};return s.d(t,"a",t),t},s.o=function(e,t){return Object.prototype.hasOwnProperty.call(e,t)},s.p="",s(s.s=21)}([function(e,t){e.exports=flarum.core.compat.app},function(e,t){e.exports=flarum.core.compat.extend},function(e,t){e.exports=flarum.core.compat["components/Button"]},function(e,t){e.exports=flarum.core.compat.Model},function(e,t){e.exports=flarum.core.compat["components/Modal"]},function(e,t){e.exports=flarum.core.compat["components/Alert"]},function(e,t){e.exports=flarum.core.compat["helpers/username"]},function(e,t){e.exports=flarum.core.compat["helpers/humanTime"]},function(e,t){e.exports=flarum.core.compat["components/UserPage"]},function(e,t){e.exports=flarum.core.compat["models/User"]},,function(e,t){e.exports=flarum.core.compat["utils/mixin"]},function(e,t){e.exports=flarum.core.compat["components/SettingsPage"]},function(e,t){e.exports=flarum.core.compat["components/Page"]},function(e,t){e.exports=flarum.core.compat.Component},function(e,t){e.exports=flarum.core.compat["components/LoadingIndicator"]},function(e,t){e.exports=flarum.core.compat["helpers/avatar"]},function(e,t){e.exports=flarum.core.compat["helpers/icon"]},function(e,t){e.exports=flarum.core.compat["components/HeaderSecondary"]},function(e,t){e.exports=flarum.core.compat["components/NotificationsDropdown"]},function(e,t){e.exports=flarum.core.compat["components/LinkButton"]},function(e,t,s){"use strict";s.r(t);var r=s(1),a=s(9),n=s.n(a),o=s(3),u=s.n(o);function i(e,t){e.prototype=Object.create(t.prototype),e.prototype.constructor=e,e.__proto__=t}var p=s(11),c=function(e){function t(){return e.apply(this,arguments)||this}return i(t,e),t}(s.n(p)()(u.a,{user:u.a.hasOne("user"),requestedUsername:u.a.attribute("requestedUsername"),status:u.a.attribute("status"),reason:u.a.attribute("reason"),createdAt:u.a.attribute("createdAt",u.a.transformDate)})),l=s(2),f=s.n(l),d=s(12),h=s.n(d),q=s(5),v=s.n(q),y=s(4),b=s.n(y),_=function(e){function t(){return e.apply(this,arguments)||this}i(t,e);var s=t.prototype;return s.init=function(){e.prototype.init.call(this),this.username=m.prop(app.session.user.username()),app.session.user.username_requests()&&this.username(app.session.user.username_requests().requestedUsername()),this.success=!1,this.password=m.prop("")},s.className=function(){return"RequestUsernameModal Modal--small"},s.title=function(){return app.translator.trans("fof-username-request.forum.request.title")},s.content=function(){return this.success?m("div",{className:"Modal-body"},m("div",{className:"Form Form--centered"},m("p",{className:"helpText"},app.translator.trans("fof-username-request.forum.request.confirmation_message")),m("div",{className:"Form-group"},m(f.a,{className:"Button Button--primary Button--block",onclick:this.hide.bind(this)},app.translator.trans("fof-username-request.forum.request.dismiss_button"))))):m("div",{className:"Modal-body"},m("div",{className:"Form Form--centered"},app.session.user.username_requests()?m("p",{className:"helpText"},app.translator.trans("fof-username-request.forum.request.current_request",{username:app.session.user.username_requests().requestedUsername()})):"",m("div",{className:"Form-group"},m("input",{type:"text",name:"text",className:"FormControl",placeholder:app.session.user.username(),bidi:this.username,disabled:this.loading})),m("div",{className:"Form-group"},m("input",{type:"password",name:"password",className:"FormControl",placeholder:app.translator.trans("core.forum.change_email.confirm_password_placeholder"),bidi:this.password,disabled:this.loading})),m("div",{className:"Form-group"},f.a.component({className:"Button Button--primary Button--block",type:"submit",loading:this.loading,children:app.translator.trans("fof-username-request.forum.request.submit_button")})),app.session.user.username_requests()?m("div",{className:"Form-group"},f.a.component({className:"Button Button--primary Button--block",onclick:this.deleteRequest.bind(this),loading:this.loading,children:app.translator.trans("fof-username-request.forum.request.delete_button")})):""))},s.deleteRequest=function(e){e.preventDefault(),this.loading=!0,app.session.user.username_requests().delete(),app.alerts.show(this.successAlert=new v.a({type:"success",children:app.translator.trans("fof-username-request.forum.request.deleted")})),app.session.user.username_requests=m.prop(),this.hide()},s.onsubmit=function(e){var t=this;e.preventDefault(),this.alert=null,this.username()!==app.session.user.username()?(this.loading=!0,app.store.createRecord("username-requests").save({username:this.username()},{meta:{password:this.password()},errorHandler:this.onerror.bind(this)}).then(function(e){app.session.user.username_requests=m.prop(e),t.success=!0}).catch(function(){}).then(this.loaded.bind(this))):this.hide()},s.onerror=function(t){401===t.status&&(t.alert.props.children=app.translator.trans("core.forum.change_email.incorrect_password_message")),e.prototype.onerror.call(this,t)},t}(b.a),N=s(13),g=s.n(N),x=s(14),w=s.n(x),k=s(15),B=s.n(k),F=s(16),j=s.n(F),M=s(6),A=s.n(M),R=s(17),U=s.n(R),O=s(7),P=s.n(O),T=function(e){function t(){return e.apply(this,arguments)||this}i(t,e);var s=t.prototype;return s.init=function(){e.prototype.init.call(this),this.request=this.props.request,this.approved=m.prop("Rejected"),this.reason=m.prop("")},s.title=function(){return app.translator.trans("fof-username-request.forum.action.title")},s.className=function(){return"RequestActionModal Modal--medium"},s.content=function(){return m("div",{className:"Modal-body"},m("div",{className:"Form"},m("h3",{className:"Notification-content"},app.translator.trans("fof-username-request.forum.action.name",{username:A()(this.request.user()),newUsername:this.request.requestedUsername()})),m("p",{className:"help"},app.translator.trans("fof-username-request.forum.action.help_text")),m("legend",null,app.translator.trans("fof-username-request.forum.action.decision_title")),m("div",{className:"Form-group"},m("label",{className:"checkbox"},m("input",{type:"radio",name:"approved",value:"Approved",checked:"Approved"===this.approved(),onclick:m.withAttr("value",this.approved)}),app.translator.trans("fof-username-request.forum.action.approval_label")),m("label",{className:"checkbox"},m("input",{type:"radio",name:"rejected",value:"Rejected",checked:"Rejected"===this.approved(),onclick:m.withAttr("value",this.approved)}),app.translator.trans("fof-username-request.forum.action.rejected_label"))),"Rejected"===this.approved()?m("div",{className:"Form-group"},m("legend",null,app.translator.trans("fof-username-request.forum.action.reason_title")),m("div",{className:"BasicsPage-reason-input"},m("textarea",{className:"FormControl",value:this.reason(),disabled:this.loading,oninput:m.withAttr("value",this.reason)}))):"",m("div",{className:"Form-group"},f.a.component({className:"Button Button--primary Button--block",type:"submit",loading:this.loading,disabled:"Rejected"===this.approved()&&!this.reason(),children:app.translator.trans("fof-username-request.forum.action.submit_button")}))))},s.onsubmit=function(e){var t=this;e.preventDefault(),this.loading=!0,this.request.save({reason:this.reason(),action:this.approved()}).then(function(){app.alerts.show(t.successAlert=new v.a({type:"success",children:app.translator.trans("fof-username-request.forum.action.success")}))}),app.cache.username_requests.some(function(e,s){e.id()==t.request.id()&&app.cache.username_requests.splice(s,1)}),m.redraw(),this.hide()},t}(b.a),C=function(e){function t(){return e.apply(this,arguments)||this}i(t,e);var s=t.prototype;return s.init=function(){this.loading=!1},s.view=function(){var e=this,t=app.cache.username_requests||[];return m("div",{className:"NotificationList RequestsList"},m("div",{className:"NotificationList-header"},m("h4",{className:"App-titleControl App-titleControl--text"},app.translator.trans("fof-username-request.forum.dropdown.title"))),m("div",{className:"NotificationList-content"},m("ul",{className:"NotificationGroup-content"},t.length?t.map(function(t){return m("li",null,m("a",{onclick:e.showModal.bind(e,t),className:"Notification Request"},j()(t.user()),U()("fas fa-user-edit",{className:"Notification-icon"}),m("span",{className:"Notification-content"},app.translator.trans("fof-username-request.forum.dropdown.item_text",{username:A()(t.user())})),P()(t.createdAt()),m("div",{className:"Notification-excerpt"},app.translator.trans("fof-username-request.forum.dropdown.exerpt",{requestedUsername:t.requestedUsername()}))))}):this.loading?B.a.component({className:"LoadingIndicator--block"}):m("div",{className:"NotificationList-empty"},app.translator.trans("fof-username-request.forum.dropdown.empty_text")))))},s.showModal=function(e){app.modal.show(new T({request:e}))},s.load=function(){var e=this;app.cache.username_requests||(this.loading=!0,m.redraw(),app.store.find("username-requests").then(function(e){delete e.payload,app.cache.username_requests=e.sort(function(e,t){return e.createdAt()-t.createdAt()})}).catch(function(){}).then(function(){e.loading=!1,m.redraw()}))},t}(w.a),S=function(e){function t(){return e.apply(this,arguments)||this}i(t,e);var s=t.prototype;return s.init=function(){e.prototype.init.call(this),app.history.push("requests"),this.list=new C,this.list.load(),this.bodyClass="App--requests"},s.view=function(){return m("div",{className:"RequestsPage"},this.list.render())},t}(g.a),L=s(0),D=s.n(L),H=s(18),I=s.n(H),G=s(19),z=function(e){function t(){return e.apply(this,arguments)||this}i(t,e),t.initProps=function(t){t.label=t.label||app.translator.trans("fof-username-request.forum.dropdown.tooltip"),t.icon=t.icon||"fas fa-user-edit",e.initProps.call(this,t)};var s=t.prototype;return s.init=function(){e.prototype.init.call(this),this.list=new C},s.goToRoute=function(){m.route(app.route("username_requests"))},s.getUnreadCount=function(){return app.cache.username_requests?app.cache.username_requests.length:app.forum.data.relationships.username_requests.data.length},s.getNewCount=function(){return app.cache.username_requests?app.cache.username_requests.length:app.forum.data.relationships.username_requests.data.length},t}(s.n(G).a),E=function(e){function t(){return e.apply(this,arguments)||this}i(t,e);var s=t.prototype;return s.init=function(){e.prototype.init.call(this),this.request=app.session.user.username_requests()},s.className=function(){return"ResultsModal Modal"},s.title=function(){return app.translator.trans("fof-username-request.forum.results.title")},s.content=function(){return"Approved"===this.request.status()?m("div",{className:"Modal-body"},m("div",{className:"Form Form--centered"},m("h2",null,app.translator.trans("fof-username-request.forum.results.approved")),m("h3",null,app.translator.trans("fof-username-request.forum.results.new_username",{username:app.session.user.username()})),m("div",{className:"Form-group"},m(f.a,{className:"Button Button--primary Button--block",onclick:this.hide.bind(this)},app.translator.trans("fof-username-request.forum.request.dismiss_button"))))):m("div",{className:"Modal-body"},m("div",{className:"Form Form--centered"},m("h2",null,app.translator.trans("fof-username-request.forum.results.rejected")),m("h3",null,app.translator.trans("fof-username-request.forum.results.reason",{reason:this.request.reason(),i:m("i",null)})),m("p",{className:"helpText"},app.translator.trans("fof-username-request.forum.results.resubmit")),m("div",{className:"Form-group"},m(f.a,{className:"Button Button--primary Button--block",onclick:this.hide.bind(this)},app.translator.trans("fof-username-request.forum.request.dismiss_button")))))},s.onhide=function(){app.session.user.username_requests=m.prop(),this.request.save({delete:!0})},t}(b.a),J=s(8),K=s.n(J),Q=function(e){function t(){return e.apply(this,arguments)||this}i(t,e);var s=t.prototype;return s.init=function(){e.prototype.init.call(this),this.loading=!0,this.loadUser(m.route.param("username"))},s.content=function(){var e=this;return m("table",{className:"NotificationGrid"},this.user.usernameHistory().slice(0).reverse().map(function(t){var s=Object.keys(t)[0];return m("tr",null,m("td",null,s),m("td",null,P()(e.calculateTime(t[s]))))}))},s.show=function(e){this.user=e,m.redraw()},s.calculateTime=function(e){return new Date(0).setUTCSeconds(e)},t}(K.a),V=s(20),W=s.n(V);app.initializers.add("fof-username-request",function(){app.store.models["username-requests"]=c,n.a.prototype.username_requests=u.a.hasOne("username_requests"),n.a.prototype.usernameHistory=u.a.attribute("usernameHistory"),app.routes.username_requests={path:"/username-requests",component:m(S,null)},app.routes.username_history={path:"/u/:username/history",component:Q.component()},Object(r.extend)(h.a.prototype,"accountItems",function(e){app.forum.attribute("canRequestUsername")&&e.add("username-request",f.a.component({className:"Button",onclick:function(){app.modal.show(new _)}},[app.translator.trans("fof-username-request.forum.account_label")]),10)}),Object(r.extend)(I.a.prototype,"items",function(e){(D.a.forum.data.relationships.username_requests&&D.a.forum.data.relationships.username_requests.data.length&&!D.a.cache.username_requests||D.a.cache.username_requests&&0!==D.a.cache.username_requests.length)&&e.add("UsernameRequests",m(z,null),20)}),new Promise(function(){setTimeout(function(){D.a.session.user&&D.a.session.user.username_requests()&&"Sent"!==D.a.session.user.username_requests().status()&&D.a.modal.show(new E)},1e3)}),Object(r.extend)(K.a.prototype,"navItems",function(e){this.user.usernameHistory()&&e.add("username-requests",W.a.component({href:D.a.route("username_history",{username:this.user.username()}),children:D.a.translator.trans("fof-username-request.forum.profile_link"),icon:"fas fa-user-edit"}))})})}]);
;

flarum.extensions['fof-username-request']=module.exports;

var module={};

module.exports=function(t){var o={};function n(r){if(o[r])return o[r].exports;var s=o[r]={i:r,l:!1,exports:{}};return t[r].call(s.exports,s,s.exports,n),s.l=!0,s.exports}return n.m=t,n.c=o,n.d=function(t,o,r){n.o(t,o)||Object.defineProperty(t,o,{enumerable:!0,get:r})},n.r=function(t){"undefined"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(t,Symbol.toStringTag,{value:"Module"}),Object.defineProperty(t,"__esModule",{value:!0})},n.t=function(t,o){if(1&o&&(t=n(t)),8&o)return t;if(4&o&&"object"==typeof t&&t&&t.__esModule)return t;var r=Object.create(null);if(n.r(r),Object.defineProperty(r,"default",{enumerable:!0,value:t}),2&o&&"string"!=typeof t)for(var s in t)n.d(r,s,function(o){return t[o]}.bind(null,s));return r},n.n=function(t){var o=t&&t.__esModule?function(){return t.default}:function(){return t};return n.d(o,"a",o),o},n.o=function(t,o){return Object.prototype.hasOwnProperty.call(t,o)},n.p="",n(n.s=10)}([function(t,o){t.exports=flarum.core.compat["helpers/icon"]},function(t,o){t.exports=flarum.core.compat.extend},function(t,o){t.exports=flarum.core.compat["components/Notification"]},function(t,o){t.exports=flarum.core.compat["components/NotificationGrid"]},function(t,o){t.exports=flarum.core.compat.Model},function(t,o){t.exports=flarum.core.compat["components/IndexPage"]},function(t,o){t.exports=flarum.core.compat["components/Dropdown"]},function(t,o){t.exports=flarum.core.compat["components/Button"]},function(t,o){t.exports=flarum.core.compat["utils/extractText"]},function(t,o){t.exports=flarum.core.compat.Component},function(t,o,n){"use strict";n.r(o);var r=n(1),s=n(3),i=n.n(s),e=n(4),a=n.n(e),u=n(5),l=n.n(u);function p(t,o){t.prototype=Object.create(o.prototype),t.prototype.constructor=t,t.__proto__=o}var c=n(6),f=n.n(c),d=n(7),b=n.n(d),g=n(0),h=n.n(g),w=n(8),_=n.n(w);function y(){return(y=Object.assign||function(t){for(var o=1;o<arguments.length;o++){var n=arguments[o];for(var r in n)Object.prototype.hasOwnProperty.call(n,r)&&(t[r]=n[r])}return t}).apply(this,arguments)}var v,x=n(9),S=function(t){function o(){return t.apply(this,arguments)||this}return p(o,t),o.prototype.view=function(){var t={onclick:this.props.onclick,disabled:this.props.disabled};return m("button",y({className:"SubscriptionMenuItem hasIcon "+(this.props.disabled&&"disabled")},t),this.props.active?h()("fas fa-check",{className:"Button-icon"}):"",m("span",{className:"SubscriptionMenuItem-label"},h()(this.props.icon,{className:"Button-icon"}),m("strong",null,this.props.label),m("span",{className:"SubscriptionMenuItem-description"},this.props.description)))},o}(n.n(x).a),j=((v={})[!1]="fas fa-star",v.follow="fas fa-star",v.lurk="fas fa-comments",v.ignore="fas fa-bell-slash",v.hide="fas fa-eye-slash",v),T=function(t){function o(){return t.apply(this,arguments)||this}p(o,t);var n=o.prototype;return n.init=function(){this.loading=m.prop(!1),this.options=[{subscription:!1,icon:j[!1],label:app.translator.trans("fof-follow-tags.forum.sub_controls.not_following_button"),description:app.translator.trans("fof-follow-tags.forum.sub_controls.not_following_text")},{subscription:"follow",icon:j.follow,label:app.translator.trans("fof-follow-tags.forum.sub_controls.following_button"),description:app.translator.trans("fof-follow-tags.forum.sub_controls.following_text")},{subscription:"lurk",icon:j.lurk,label:app.translator.trans("fof-follow-tags.forum.sub_controls.lurking_button"),description:app.translator.trans("fof-follow-tags.forum.sub_controls.lurking_text")},{subscription:"ignore",icon:j.ignore,label:app.translator.trans("fof-follow-tags.forum.sub_controls.ignoring_button"),description:app.translator.trans("fof-follow-tags.forum.sub_controls.ignoring_text")},{subscription:"hide",icon:j.hide,label:app.translator.trans("fof-follow-tags.forum.sub_controls.hiding_button"),description:app.translator.trans("fof-follow-tags.forum.sub_controls.hiding_text")}]},n.view=function(){var t=this,o=this.props.tag,n=o.subscription()||!1,r=app.translator.trans("fof-follow-tags.forum.sub_controls.follow_button"),s=j[n]||"far fa-star",i="SubscriptionMenu-button--"+n;if(["follow","lurk","ignore","hide"].includes(n)){var e=["ignore","hide"].includes(n)?n.slice(0,n.length-1):n;r=app.translator.trans("fof-follow-tags.forum.sub_controls."+e+"ing_button")}var a=app.session.user.preferences(),u=a.notify_newPostInTag_email,l=a.notify_newPostInTag_alert,p=_()(app.translator.trans(u?"fof-follow-tags.forum.sub_controls.notify_email_tooltip":"fof-follow-tags.forum.sub_controls.notify_alert_tooltip")),c={className:"Button SubscriptionMenu-button "+i,icon:s,children:r,onclick:this.saveSubscription.bind(this,o,!["follow","lurk","ignore","hide"].includes(n)&&"follow"),title:p,loading:this.loading()};return(u||l)&&!1===n?c.config=function(t){$(t).tooltip({container:".SubscriptionMenu",placement:"bottom",delay:250,title:p})}:(c.config=function(t){return $(t).tooltip("destroy")},delete c.title),m("div",{className:"Dropdown ButtonGroup SubscriptionMenu App-primaryControl"},b.a.component(c),m("button",{className:"Dropdown-toggle Button Button--icon "+i,"data-toggle":"dropdown"},h()("fas fa-caret-down",{className:"Button-icon"})),m("ul",{className:"Dropdown-menu dropdown-menu Dropdown-menu--right"},this.options.map((function(r){return r.onclick=t.saveSubscription.bind(t,o,r.subscription),r.active=n===r.subscription,r.disabled="hide"===r.subscription&&o.isHidden(),m("li",null,S.component(r))}))))},n.saveSubscription=function(t,o){var n=this;this.loading(!0),app.request({url:app.forum.attribute("apiUrl")+"/tags/"+t.id()+"/subscription",method:"POST",data:{data:{subscription:o}}}).then((function(t){return app.store.pushPayload(t)})).then((function(){n.loading(!1),m.lazyRedraw()})),this.$(".SubscriptionMenu-button").tooltip("hide")},o}(f.a),I=n(2),N=n.n(I),O=function(t){function o(){return t.apply(this,arguments)||this}p(o,t);var n=o.prototype;return n.icon=function(){return"fas fa-user-tag"},n.href=function(){var t=this.props.notification.subject();return app.route.discussion(t)},n.content=function(){return app.translator.trans("fof-follow-tags.forum.notifications.new_discussion_text",{user:this.props.notification.fromUser(),title:this.props.notification.subject().title()})},o}(N.a),P=function(t){function o(){return t.apply(this,arguments)||this}p(o,t);var n=o.prototype;return n.icon=function(){return j.lurk},n.href=function(){var t=this.props.notification,o=t.subject(),n=t.content()||{};return app.route.discussion(o,n.postNumber)},n.content=function(){return app.translator.trans("fof-follow-tags.forum.notifications.new_post_text",{user:this.props.notification.fromUser()})},o}(N.a);app.initializers.add("fof/follow-tags",(function(){app.initializers.has("flarum-tags")?(app.store.models.tags.prototype.subscription=a.a.attribute("subscription"),Object(r.extend)(l.a.prototype,"sidebarItems",(function(t){if(this.currentTag()&&app.session.user){var o=this.currentTag();t.replace("newDiscussion",t.get("newDiscussion"),10),t.add("subscription",T.component({tag:o,itemClassName:"App-primaryControl"}),5)}})),app.notificationComponents.newPostInTag=P,app.notificationComponents.newDiscussionInTag=O,Object(r.extend)(i.a.prototype,"notificationTypes",(function(t){t.add("newDiscussionInTag",{name:"newDiscussionInTag",icon:"fas fa-user-tag",label:app.translator.trans("fof-follow-tags.forum.settings.notify_new_discussion_label")}),t.add("newPostInTag",{name:"newPostInTag",icon:"fas fa-user-tag",label:app.translator.trans("fof-follow-tags.forum.settings.notify_new_post_label")})}))):console.error("!! flarum/tags is not enabled")}),-1)}]);
;

flarum.extensions['fof-follow-tags']=module.exports;

Expected Behavior
That semi column doesn't appear to have any purpose.

Environment

  • Flarum version: beta 12

Possible Solution
The semi column is added here https://github.com/flarum/core/blob/d492579638fb52dafbfe65f1f36a95eb6047f7f3/src/Frontend/Compiler/JsCompiler.php#L72 after each javascript file added through ->addFile().

I can't think of any reason for it to be there, and the git blame seems to indicate it was there from the start. It seems we could simply remove it (?)

Was it a copy-paste mistake at some point maybe ?

@nlssn
Copy link
Contributor

nlssn commented Jun 8, 2020

@clarkwinkelmann I would like to fix this, if that's ok? It would be my very first PR.

@clarkwinkelmann
Copy link
Member Author

I suppose you can yes. Nobody has shared any insights about why it exists and I think it's unlikely we will find a reason to keep it.

@dsevillamartin dsevillamartin changed the title Unwanted semicolumn in assets files Unwanted semicolon in assets files Jun 8, 2020
@dsevillamartin
Copy link
Member

I've fixed the title - I was a bit confused when I read it as I thought it was DB related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants