Default settings values are not returned

[imorland]

Bug Report

Current Behavior
When calling $settings->get('some-key-that-is-not-already-in-the-database'), having already defined a default value in an extensions' extend.php, the value returned is null

Steps to Reproduce

• In extend.php

new (Extend\Settings())
  ->default('some-key-that-is-not-already-in-the-database', 'my-default-value'),

• Call that settings key

$settings->get('some-key-that-is-not-already-in-the-database')

• Notice the value is null

Expected Behavior
The default value as defined in extend.php should be returned.

Environment

• Flarum version: 1.3
• Website URL: local
• Webserver: n/a
• Hosting environment: n/a
• PHP version: 8.0.13
• Browser: n/a

Additional Context
Add any other context about the problem here.

[davwheat]

I noticed this too but assumed it was an issue with my local setup.

[SychO9]

I can reproduce this, which I find very confusing as the test still succeeds, I also remember testing this extender very well 🤔

allow me to investigate this.

framework/framework/core/tests/integration/extenders/SettingsTest.php

Lines 170 to 184 in 584884a

	public function custom_setting_default_prioritizes_extender()
	{
	$this->extend(
	(new Extend\Settings())
	->serializeToForum('customPrefix.unavailableCustomSetting3', 'custom-prefix.unavailable_custom_setting3')
	->default('custom-prefix.unavailable_custom_setting3', 'extenderDefault')
	);
	$value = $this->app()
	->getContainer()
	->make('flarum.settings')
	->get('custom-prefix.unavailable_custom_setting3', 'defaultParameterValue');
	$this->assertEquals('extenderDefault', $value);
	}