From 60b526204abf00fa7d82a9f7ffedf4f5fb22ed26 Mon Sep 17 00:00:00 2001 From: Alexander Skvortsov <38059171+askvortsov1@users.noreply.github.com> Date: Mon, 4 Jan 2021 18:31:05 -0500 Subject: [PATCH] Fix deleting posts/discussions by deleted user Making the $user argument nullable prevents this unnecessary exception, and doesn't introduce any issues since we check that $user exists as part of the method. --- src/User/UserMetadataUpdater.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/User/UserMetadataUpdater.php b/src/User/UserMetadataUpdater.php index 19bb2e8fec..5e0252e589 100644 --- a/src/User/UserMetadataUpdater.php +++ b/src/User/UserMetadataUpdater.php @@ -65,7 +65,7 @@ public function whenDiscussionWasDeleted(DiscussionDeleted $event) /** * @param \Flarum\User\User $user */ - private function updateCommentsCount(User $user) + private function updateCommentsCount(?User $user) { if ($user && $user->exists) { $user->refreshCommentCount()->save();