Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mentions pop-up doesn't close with Escape #32

Open
davwheat opened this issue Oct 12, 2021 · 0 comments
Open

Mentions pop-up doesn't close with Escape #32

davwheat opened this issue Oct 12, 2021 · 0 comments
Assignees
@askvortsov1
Labels
type/bug

Comments

@davwheat
Copy link
Member

davwheat commented Oct 12, 2021 •
edited
Loading

Bug Report

Current Behavior
The mentions pop-up doesn't stay closed when Escape is pressed.

Steps to Reproduce

  1. Start mentioning a user
  2. Press escape
  3. Pop-up closed for a split second, then immediately reappears

Expected Behavior
Pop-up should stay closed.

Screenshots

EUbIyPuem8.mp4

Environment
Discuss 1.1 pre-release & Demo 1.0 deployment

Possible Solution

I'm guessing that the pop-up is opened on keypress, and we don't filter out the escape key when deciding to open it.
@askvortsov1 askvortsov1 self-assigned this Oct 12, 2021
@askvortsov1 askvortsov1 transferred this issue from flarum/framework Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@askvortsov1 askvortsov1

Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davwheat @askvortsov1