Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: additional precision for log timestamps #528

Open
alextes opened this issue Sep 14, 2023 · 3 comments
Open

Feature request: additional precision for log timestamps #528

alextes opened this issue Sep 14, 2023 · 3 comments

Comments

@alextes
Copy link
Contributor

alextes commented Sep 14, 2023

It seems current log lines add timestamps with second-level precision. In our logging infra this results in thousands of logs sharing the same timestamp which hurts our ability to look at the order of logs. One can drill down on log specific, precise timestamps as infra allows but this loses ordering between log types still.

Open to a PR flipping on precise timestamps? Was this left at the current precision intentionally perhaps?

From what I read logrus accepts go time formats, so setting TimestampFormat to time.RFC3339Nano could be nice, which would provide nanosecond level timestamps.

@alextes alextes changed the title Question: why no full timestamp in JSON logs? Feature request: additional precision for log timestamps Sep 14, 2023
@metachris
Copy link
Collaborator

We could discuss changing the timestamp format to RFC3339Nano! Could you open a PR? Then we can circulate this across the broader boost relay community and ask for input, I don't see a blocker right away.

@metachris
Copy link
Collaborator

timestamps may be a bit easier to parse though, not sure if some operators have a strong opinion of timestamp in milliseconds vs RFC3339Nano 🤔 let's start a conversation!

@alextes
Copy link
Contributor Author

alextes commented Oct 5, 2023

Created a PR: #537 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants