Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eip1559 integration #70

Closed
thegostep opened this issue May 26, 2021 · 6 comments
Closed

eip1559 integration #70

thegostep opened this issue May 26, 2021 · 6 comments
Assignees

Comments

@thegostep
Copy link

No description provided.

@pgebheim
Copy link

pgebheim commented May 26, 2021

The current PR for 1559 from geth -- ethereum#22896

Mev-Geth Tasks:

  • Investigate if Ethers handles 1559 encoding for tests (T/J)

  • figure out how running eip-1599 in a local test net even works, ie. can we easily control the basefee in the header (T/J)

  • update end to end tests to use eip-1559 tests (T/J)

    • Make sure we enable the london fork
  • mev-geth load test - update to support 1559 (T/J)

  • Add test cases for consensus changes:

    • There is a new rule added friday, we may need to check that things work,
    • sender balancer is greater than maxFeePerGas*gasLimit
    • priority fee per gas <= max fee per gas
  • add test for bundle with a tx below the block header basefee

  • update sponsored tx to rely on pre-inbound eth instead of post-payment of 0-gas-price (J)

  • eth_callBundle updates (J)

    • Update gas price
    • Use new fee tip
    • Check base fee

Relay Changes:

  • Almost nothing should need to change here.
  • Update the hard cutoff for gas price (gasnow endpoint, hardcoded value)

Not mev-geth:

  • Update blocks api
  • Survey miners and asking if they're planning on moving forward with EIP1559 (Tomasz/Tina?)
    • Is there anything they require us to deliver?

Timeline:

  • Original geth timeline was pushed because of a consensus, so Friday the 11th the timelines will be decided on.
  • For our planning
  • 14/15th a likely date first testnet to exist -- could be delayed.
  • 15th of July is earliest date for mainnet
  • Goerli Date ~~ 23rd of June

Testing:

  • Been relying on end-to-end tests
  • Could revisit trying to do more unit test -- it's very complicated
  • Investigate connecting mev-geth as a validator to Calaveras (end to end)

Discussion Future Notes:

  • Add better End to End testing Structure
  • Research: Are there efficient ways to capture value by arbing between legacy and eip1559 txn

@pgebheim
Copy link

@Zachinquarantine
Copy link

any update on this?

@Zachinquarantine
Copy link

#80

@pgebheim
Copy link

pgebheim commented Jul 9, 2021

Yes,

The implementation changes here -- https://github.com/flashbots/mev-geth/tree/release/v1.10.4-mev0.3. This has been deployed to Goerli and has been running since the Goerli switchover to london.

@jparyani
Copy link

Newest branch is based on upstream v1.10.5, https://github.com/flashbots/mev-geth/tree/release/v1.10.5-mev0.3. Also it has been pushed to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants