Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include sanctions checking for regions outside U.S. #98

Closed
jackturnbull opened this issue Aug 15, 2022 · 4 comments
Closed

Include sanctions checking for regions outside U.S. #98

jackturnbull opened this issue Aug 15, 2022 · 4 comments

Comments

@jackturnbull
Copy link

Hi Flashbots,

I'd originally attempted to submit a PR #96 without first realising that the contribution guidelines stated that I must first submit an issue. Unfortunately my PR was closed without any rationale on why, nor any pathways to rectify this. While the wording was tongue-in-cheek (I acknowledge) the intent was transparent and I believe that you there is a strong case to be made for expanding the sanctions checking to nations other than the U.S.

My problems with this process so far:

  • Your approach to sactions maintenance is completely undocumented.
    • effect: how was I meant to know that this PR isn't helpful? Do you only consider sanctions from the U.S. to be valid?
  • Your approach to rectifying this PR is unhelpful.
    • effect: what was the issue with this PR? Why was it closed?

Despite the comments on the PR being spam-like, and brigade-like I would like to make the case to open this PR based on the following:

  • AFAIK, Flashbots is an international organisation with members around the world, as noted in Removes OFAC blacklist. #92.
  • This is an honest, in essence, attempt to level the playing field on the sanctions handling: I have not invented the sanction address and this is very much a real, legally binding sanction from the UK government. Nor am I attempting to conceal it's weight, it is equally as valid as that of OFAC. It just happens to not be the U.S. government.

While I'd like to be wrong, it feels disappointing to see any project hide behind contribution guidelines for discouraging conversation and to ensure that my next attempt meets all contribution guidelines I am creating this issue before re-raising the PR.

@come-maiz
Copy link
Contributor

Your PR wording was tongue-in-cheek, that's non-compliant (a very trendy word this days) with our contribution guidelines. When you come with clear questions in a helpful manner, we will happily receive you. This is clear on everything we do, and necessary for our personal sanity and collective health.

@jackturnbull
Copy link
Author

jackturnbull commented Aug 15, 2022

Absolutely - and I understand that you need to draw the line at certain communication styles for efficiency, no harm done in that regard.

I would therefore like to propose a couple of clear questions that are hopeully taken on face-value, with no malintent:

  • Is Flashbots only indending to adhere to sanctions within the U.S.? Rephrase; is not interested in compliance outside of the U.S.?
  • Are you able to offer guidance or documentation on which sanctions lists you intend to support, and why?

Edit; The answer here might probably just be; we're just a bunch of developers trying to build some tooling and we don't want to go to jail, and honestly I'd absolutely understand that. But these things may define lines in the sand for years to come and it's unchartered territory - this is worth the analysis, and where you have time to participate I believe everyone would appreciate the discussion and your thoughts.

@Pandapip1
Copy link

Pandapip1 commented Aug 15, 2022

I propose that #99 supersede this issue. The rationale for each is similar, but #99 allows more customizability for the user, reduces flashbots developer workload in the long run, and means that flashbots doesn't have to comply with the regulations of all ~200 countries arount the world, which may be incompatible with one another.

@jackturnbull
Copy link
Author

Added further comment over here (#96 (comment)) to be used for people looking back at this in future who may have missed some context on why this was created.

I maintain my stance that on a rational level that the UK sanctions list is as equally valid for inclusion as the US one, and inclusion of one should make the other valid, but I don't believe the Flashbots team want to face this head on. The original PR wase closed due to being "not helpful, for obvious reasons." I would make a straight argument that the content of the code is helpful, written in the style of the repo, cleanly, and with tests and should be merged on its own merit.

But if there is to be no engagement around the content of the code and it's merit (or why it was not valid for inclusion outside of moderation), and nor do I expect there to be any engagement on this open issue, then I won't push it any further and clean this up in the mean-time by closing it.

@jackturnbull jackturnbull closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants