Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable gas snapshots on CI #5

Open
ferranbt opened this issue Jan 3, 2024 · 4 comments
Open

Enable gas snapshots on CI #5

ferranbt opened this issue Jan 3, 2024 · 4 comments
Labels
ci good first issue Good for newcomers

Comments

@ferranbt
Copy link
Collaborator

ferranbt commented Jan 3, 2024

No description provided.

@ferranbt ferranbt added the ci label Jan 6, 2024
@ferranbt ferranbt added the good first issue Good for newcomers label Feb 1, 2024
@d0ra-1h3-3xpl0ra
Copy link

Could you spec it out? Can help on this one. lmk

@ferranbt
Copy link
Collaborator Author

Hey! Sure, this CI check is not working. Gas snapshots I generate on my machine are different from the ones calculated in CI.

@d0ra-1h3-3xpl0ra
Copy link

kk, I'll look into it this week and try to fix it. Anything else I should consider and could you share a screenshot of the gas snapshot output error/diff?

@ferranbt
Copy link
Collaborator Author

https://github.com/flashbots/suave-std/actions/runs/7397881257/job/20125834160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ferranbt @d0ra-1h3-3xpl0ra