-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Change project name from coreos to flatcar-linux #241
Conversation
client := packngo.NewClientWithAuth("github.com/coreos/mantle", opts.ApiKey, nil) | ||
client := packngo.NewClientWithAuth("github.com/flatcar-linux/mantle", opts.ApiKey, nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this change can break access to packet API. Should this stay as github.com/coreos/mantle
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like a token to identify the generated client in order to keep it across the codebase (and avoid generating new client each time?).
Checking the codebase: https://github.com/packethost/packngo/blob/b666b4ebebb1f0fba2a9ad79428fa79daf0774e2/packngo.go#L334-L342
a regular NewClient
will populate this field with packngo lib
so I guess we can put whatever we want inside.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see, if we get some problems with packet, then we can revert this one change.
dc5dd81
to
23413cb
Compare
23413cb
to
e11adca
Compare
Thanks ! That looks good (CI is green) - can we just remove the |
Thanks for the review. Dropped the file and updated the change log. |
Now that the Github org name of mantle was changed from coreos to flatcar-linux, via flatcar/mantle#241, we need to change the Github org name in ebuilds as well.
Now that the Github org name of mantle was changed from coreos to flatcar-linux, via flatcar/mantle#241, we need to change the Github org name in ebuilds as well.
Now that the Github org name of mantle was changed from coreos to flatcar-linux, via flatcar/mantle#241, we need to change the Github org name in ebuilds as well.
Now that the Github org name of mantle was changed from coreos to flatcar-linux, via flatcar/mantle#241, we need to change the Github org name in ebuilds as well.
Now that the Github org name of mantle was changed from coreos to flatcar-linux, via flatcar/mantle#241, we need to change the Github org name in ebuilds as well.
This just renames the project from
github.com/coreos/mantle
togithub.com/flatcar-linux/mantle
.