Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Change project name from coreos to flatcar-linux #241

Merged
merged 3 commits into from
Oct 6, 2021

Conversation

krnowak
Copy link
Member

@krnowak krnowak commented Oct 5, 2021

This just renames the project from github.com/coreos/mantle to github.com/flatcar-linux/mantle.

client := packngo.NewClientWithAuth("github.com/coreos/mantle", opts.ApiKey, nil)
client := packngo.NewClientWithAuth("github.com/flatcar-linux/mantle", opts.ApiKey, nil)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this change can break access to packet API. Should this stay as github.com/coreos/mantle?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a token to identify the generated client in order to keep it across the codebase (and avoid generating new client each time?).
Checking the codebase: https://github.com/packethost/packngo/blob/b666b4ebebb1f0fba2a9ad79428fa79daf0774e2/packngo.go#L334-L342

a regular NewClient will populate this field with packngo lib so I guess we can put whatever we want inside.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see, if we get some problems with packet, then we can revert this one change.

@tormath1
Copy link
Contributor

tormath1 commented Oct 6, 2021

Thanks ! That looks good (CI is green) - can we just remove the .travis.yml while we're here and also add a changelog entry under the https://github.com/flatcar-linux/mantle/blob/v0.17.0/CHANGELOG.md#changed section (you might need to rebase to avoid conflict since we released yesterday)

@krnowak
Copy link
Member Author

krnowak commented Oct 6, 2021

Thanks for the review. Dropped the file and updated the change log.

@krnowak krnowak merged commit 8c0dcb3 into flatcar-master Oct 6, 2021
@krnowak krnowak deleted the krnowak/rename branch October 6, 2021 13:14
dongsupark added a commit to flatcar-archive/coreos-overlay that referenced this pull request Dec 3, 2021
Now that the Github org name of mantle was changed from coreos to
flatcar-linux, via flatcar/mantle#241,
we need to change the Github org name in ebuilds as well.
dongsupark added a commit to flatcar-archive/coreos-overlay that referenced this pull request Dec 3, 2021
Now that the Github org name of mantle was changed from coreos to
flatcar-linux, via flatcar/mantle#241,
we need to change the Github org name in ebuilds as well.
dongsupark added a commit to flatcar-archive/coreos-overlay that referenced this pull request Feb 28, 2022
Now that the Github org name of mantle was changed from coreos to
flatcar-linux, via flatcar/mantle#241,
we need to change the Github org name in ebuilds as well.
dongsupark added a commit to flatcar-archive/coreos-overlay that referenced this pull request Feb 28, 2022
Now that the Github org name of mantle was changed from coreos to
flatcar-linux, via flatcar/mantle#241,
we need to change the Github org name in ebuilds as well.
t-lo pushed a commit to flatcar/scripts that referenced this pull request Apr 13, 2023
Now that the Github org name of mantle was changed from coreos to
flatcar-linux, via flatcar/mantle#241,
we need to change the Github org name in ebuilds as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants