Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Update the default Go to 1.21 with exceptions of Docker/containerd #1382

Closed
3 tasks done
dongsupark opened this issue Mar 4, 2024 · 7 comments
Closed
3 tasks done
Labels
kind/feature A feature request

Comments

@dongsupark
Copy link
Member

dongsupark commented Mar 4, 2024

Current situation

By default Flatcar uses Go 1.20 for all packages.

However, Go 1.20 is already EOL, so it gets no security update at all.
So Flatcar should have Go 1.21. At the same time, the default Go version should be updated to 1.21, and then Go 1.19 can be dropped from the Flatcar SDK.

On the other hand, as upstream projects Docker 24.0.x and containerd 1.7.x are still with Go 1.20, those exceptions should still stay with 1.20.

The thing is, ebuilds of the projects, being synced with Gentoo, do not rely on coreos-go-*.eclass any more. As a result, there is no simple way to specifically pin Go version for each case.

Status of the current blockers:

blocks #1387

@dongsupark dongsupark added the kind/feature A feature request label Mar 4, 2024
@dongsupark dongsupark mentioned this issue Mar 6, 2024
@dongsupark
Copy link
Member Author

blocks #1387

@dongsupark
Copy link
Member Author

Updated description for the current blockers.
Docker and runc are still open blockers.

@pothos
Copy link
Member

pothos commented Apr 2, 2024

Thanks, the runc PR looks close to land, and since Docker 25 doesn't block on the runc release we can already start updating Docker to have everything in place once the runc release is ready.

@pothos
Copy link
Member

pothos commented Apr 8, 2024

I think we can also build runc with 1.21 and let kola check if we have any issues (The readme says runc only supports Linux. It must be built with Go version 1.19 or higher. - but there is an open issue about breakage with 1.22, I hope that 1.21 would work, though).

@tormath1
Copy link
Contributor

For what is worth, it's going to block the Incus addition too. I'm currently testing Incus with a custom patch to use Go 1.21.

@tormath1
Copy link
Contributor

It seems that runc is now using go 1.21: opencontainers/runc@6b2eb52

@tormath1
Copy link
Contributor

tormath1 commented Aug 1, 2024

Done here: flatcar/scripts#2152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A feature request
Projects
Development

No branches or pull requests

3 participants