Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move docker build to developer container #1529

Open
1 of 4 tasks
krnowak opened this issue Sep 2, 2024 · 0 comments
Open
1 of 4 tasks

Move docker build to developer container #1529

krnowak opened this issue Sep 2, 2024 · 0 comments
Labels
kind/feature A feature request

Comments

@krnowak
Copy link
Member

krnowak commented Sep 2, 2024

Currently the built-in docker build command is deprecated in favor of the buildkit plugin. There's a PR (flatcar/scripts#2204) that adds the plugin to the generic image (or rather, to the docker sysext, which is a part of the generic image). Since the docker build is rather of a limited use without the build tools, it should rather be a part of the developer container.

The plan:

  • Merge Add app-containers/docker-buildx scripts#2204, so generic image has a buildx plugin, no pesky deprecation messages are printed.
  • Turn developer container into a sysext image.
  • Start a deprecation period by announcing the move of the buildkit plugin to the developer sysext.
  • Add a stub buildkit binary that prints a message about how to get a working docker build command or patch the docker binary to do it.

Notes:

Patching the docker binary might be preferrable despite having to maintain the patch, because if docker-sysext and developer container sysext both provide the buildkit plugin (a proper one and a stub one, respectively), then which one will end up on the merged filesystem depends on ordering of sysexts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A feature request
Projects
Status: 📝 Needs Triage
Development

No branches or pull requests

1 participant