Enable TLS support #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a requirement for the spacemacs develop branch. See also: syl20bnr/spacemacs#11585 Fixes flathub#19
|
Started test build 20511 |
|
Build 20511 successful |
|
Change by itself looks good. However, I am surprised that it is required - even current builds of Emacs in this flatpak are linked against gnutls. Does the problem get addressed by installing the test build from #26 (comment) ? |
|
Yes I confirm the test build works. Spacemacs develop branch now works fine. |
|
I am a bit baffled that it does not work by default, when it clearly is doing something with gnutls already. But it should be reasonably safe to explicitly enable the support. |
|
Oh, and thank you @philn for providing a fix for it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a requirement for the spacemacs develop branch.
See also: syl20bnr/spacemacs#11585
Fixes #19