Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xwidget and other modules #32

Open
A6GibKm opened this issue Sep 29, 2020 · 1 comment
Open

Xwidget and other modules #32

A6GibKm opened this issue Sep 29, 2020 · 1 comment

Comments

@A6GibKm
Copy link

A6GibKm commented Sep 29, 2020

I regularly need a clean Emacs build to test stuff and compare to behaviours with other Emacs branches or forks, it would be nice to have xwidgets for example, see #13.

I can make such a PR if there is any interest on this @muep . Same applies to flags as --with-modules, --with-jansson (required for new json native parser in Emacs 27), harfbuzz (Also introduced in Emacs 27), --with-cairo, --with-gtk3, etc. Which are some of the most popular flags.

Of course each of these features would be on its own PR and priority would be for xwidgets and the features added in emacs 27.

@muep
Copy link
Collaborator

muep commented Jan 16, 2021

@A6GibKm sorry for the long response. I am now finding more time to pay attention to this flatpak. This means that at least I am more open to having a small number of libraries bundled. Jansson seems to already be arriving in #36.

My impression is that for most of these optional features, we seem to require bundling of deps - simply adding a flag will not work since Emacs configure step would typically automatically enable all the features whose requirements are satisfied.

Feel free to submit PRs, though I also have plans to check through the issues this weekend. For each added dependency, I think we should assess the benefit/risk a bit. For the Jansson PR it seems that a single trivially building dependency suffices, and it seems to be a pretty mature library, rarely requiring urgent patching. I suppose that bundling a webkitgtk will be more exciting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants