-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to automate release of new versions #216
base: master
Are you sure you want to change the base?
Conversation
Started test build 78771 |
5f10034
to
9abaeb6
Compare
Started test build 78772 |
Build 78771 successful
|
Build 78772 successful
|
Very cool! Could we disable push by default? Or enable |
9abaeb6
to
78999f7
Compare
Started test build 78796 |
Yes, I inverted the option to |
Build 78796 successful
|
78999f7
to
fae0d5e
Compare
Started test build 78912 |
Build 78912 successful
|
Seem to be getting this error when running. Am I running it wrong?
|
Hi, thanks for testing this. So, shell script is a complicated beast compatibility-wise. This seems to be a problem with dash and non-quoted variable assignment. I've used the opportunity while working on this script to improve my knowledge of POSIX-compliant shell script, testing with bash, dash, zsh and ash/busybox on an Alpine container, and still I let this one slip. That's how hard shell compatibility is. What shell are you using? What OS? PS: I just fixed it, but the fix broke zsh 😬 |
We could flip it to use Node.js, or Python, or anything 🤷 |
I wanted something with no dependencies, so it would run on any CI server so I wouldn't need to care to ask what's running on it. And I also wanted to improve my script-fu. And shell script always feels like a good fit for build automation. Anyway, I fixed it, it was just some creative quoting on my part. Quoting rules are by far the most complicated part of shell script in my opinion. I'm waiting one hour just to test some more. Github has a very low rate limit for their API, I can only test the script about 7 times before hitting it. |
fae0d5e
to
7fdaea9
Compare
Started test build 80480 |
@RobLoach I've amended and force-pushed it. Tested with on every shell this time. |
Build 80480 successful
|
New year, new PR. Same issues... Still trying to resolve #189
So, what changed:
I've come to accept that I'll never reach out to the guys on Discord to work on the upstream CI, so the problem has to be solved on this repository alone. I've decided to use the GitHub API to get the last commit hashes from the repositories of the modules and just update the template with that. Sounds like a cheap lazy excuse of a solution, but in fact it works much better than I expected.
I've just created a test release on a local branch with this command:
[UPDATED with the changes discussed in comments below]
You can use
--help
to get the usual usage help. Note that the script commits to git and creates a tag, so use a branch to test and take care not to push test releases.This time it works, I swear.