Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming sections #341

Open
jmcmurry opened this issue Apr 10, 2020 · 3 comments
Open

Renaming sections #341

jmcmurry opened this issue Apr 10, 2020 · 3 comments
Labels

Comments

@jmcmurry
Copy link
Contributor

jmcmurry commented Apr 10, 2020

If these sections get renamed; will this break things?
| 04-yes-this-is-bad.md | OK
  | 05-this-is-not-normal-flu.md | OK
  | 06-keep-the-main-thing-the-main-thing.md | OK
  | 07-it-is-here.md | OK
  | 08-the-us-healthcare-system.md | No one is prepared
  | 09-relative-to-other-countries.md | Policies that help pandemic control
  | 10-there-is-hope.md | ok

@emersonthis
Copy link
Collaborator

Possible duplicate of #294 ?

@rousik
Copy link
Collaborator

rousik commented Apr 23, 2020

It seems to me that Lokalise derives translation keys from filenames so changing filenames will result in "loss of translated strings" for each of these files. That said I'm currently investigating whether we could somehow group the duplicates in Lokalise and prevent this loss.

@rousik
Copy link
Collaborator

rousik commented Apr 24, 2020

I have not found a good way to reconcile change of keys. For the recent act_and_prepare we have just decided to let it be translated and ported to the new keys. This was mainly because we did both content change and rename at the same time.

If we can ensure that translations of those keys are up to date, we might port the existing translations to the new keys in an automated fashion rather than have humans do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants