Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be support mobile #10

Open
TinoPham opened this issue Jan 30, 2015 · 2 comments
Open

Should be support mobile #10

TinoPham opened this issue Jan 30, 2015 · 2 comments

Comments

@TinoPham
Copy link

I think should be have color selector for mobiles to users choose easier.

@nurikabe
Copy link

nurikabe commented Jul 7, 2015

+1

@jtlocsei
Copy link

+1. It works on mobile, but you need to tap the color swatch twice, which feels like a sub-optimal user experience.

With a bit of experimentation I found that I could fix the issue by making two changes to bootstrap-colorselector.js:

Change 1:
$markupUl.on('click.colorselector', $.proxy(this._clickColor, this));
to
$markupUl.on('click.colorselector touchend.colorselector', $.proxy(this._clickColor, this));

Change 2:
Change
e.preventDefault();
to
// e.preventDefault();
i.e. comment out that line. For some reason, that was preventing the dropdown from closing once you tapped it on a touchscreen. And it doesn't seem necessary anyway on a normal screen.

Hope this is useful to someone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants