Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrub_css drops !important rule from shorthand css properties #191

Closed
b7kich opened this issue Aug 25, 2020 · 5 comments
Closed

scrub_css drops !important rule from shorthand css properties #191

b7kich opened this issue Aug 25, 2020 · 5 comments

Comments

@b7kich
Copy link

b7kich commented Aug 25, 2020

Applies to shorthand CSS properties like border, padding, margin, background and their expansions like margin-top, background-color etc.

[1] pry(main)> puts Loofah::fragment('<h1 style="background: black !important; color: white !important; ">got milk?</h1>').scrub!(:prune)
<h1 style="background:black;color: white !important;">got milk?</h1>
b7kich pushed a commit to b7kich/loofah that referenced this issue Aug 25, 2020
@christiankisssner
fixed: scrub_css drops !important rule from shorthand css properties f…
9816491 
…lavorjones#191
@b7kich b7kich mentioned this issue Aug 26, 2020
Merged
@flavorjones
Copy link
Owner

Thanks for reporting this. I'll take a look at the PR at #192 today.

flavorjones pushed a commit to b7kich/loofah that referenced this issue Aug 26, 2020
@christiankisssner @flavorjones
scrub_css should not drop !important from shorthand css props
50931f4 
part of flavorjones#191
flavorjones added a commit to b7kich/loofah that referenced this issue Aug 26, 2020
@flavorjones
prefer Array#<< to creating a new array
ea6fe90 
and clean up test data

part of flavorjones#191
flavorjones added a commit to b7kich/loofah that referenced this issue Aug 26, 2020
@flavorjones
update CHANGELOG
0aba0b9 
part of flavorjones#191
@flavorjones
Copy link
Owner

Will ship in v2.7.0 later today.

@flavorjones
Copy link
Owner

https://github.com/flavorjones/loofah/releases/tag/v2.7.0

@b7kich
Copy link
Author

b7kich commented Aug 27, 2020

Thanks for cleaning the code up!

@flavorjones
Copy link
Owner

No, thank you for figuring out the bug and submitting a PR! This was a tricky one. 👍

This was referenced Mar 11, 2021
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flavorjones @b7kich