Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border-style keywords #188

Merged
merged 2 commits into from
Jun 16, 2020
Merged

Conversation

tarcisiozf
Copy link

Hi, I'm having some issues when trying to sanitize elements with border-style. I've added the missing keywords following the spec: https://developer.mozilla.org/en-US/docs/Web/CSS/border-style

Copy link
Owner

@flavorjones flavorjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add these into ACCEPTABLE_CSS_KEYWORDS in alphabetical order?

@flavorjones
Copy link
Owner

@tarcisiozf Thank you for submitting this! Looks great, just had one request which was to follow the convention of listing attributes and keywords in alphabetical order.

@flavorjones
Copy link
Owner

@tarcisiozf Just wanted to check if you are open to making the change I requested?

@tarcisiozf
Copy link
Author

@flavorjones sorry for taking so long to answer, I'll do the requested changes.

@tarcisiozf
Copy link
Author

@flavorjones done, did I miss anything else?

@flavorjones
Copy link
Owner

Looks good, thank you! Merging.

@flavorjones flavorjones merged commit e14b903 into flavorjones:master Jun 16, 2020
@flavorjones
Copy link
Owner

I've shipped loofah v2.6.0 with this change in it, and credited you in the CHANGELOG. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants