Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] InteractiveFlags.all does not include doubleTapDragZoom and scrollWheelZoom #1725

Closed
amal-stack opened this issue Nov 10, 2023 · 0 comments · Fixed by #1726
Closed
Labels
bug This issue reports broken functionality or another error
Milestone

Comments

@amal-stack
Copy link
Contributor

amal-stack commented Nov 10, 2023

What is the bug?

The bits for the newly added interactive flags InteractiveFlag.doubleTapDragZoom and InteractiveFlag.scrollWheelZoom are not included in the InteractiveFlags.all constant.

How can we reproduce it?

The following code prints false for both flags:

void main() {
  print('Has double tap drag zoom: ${InteractiveFlag.hasDoubleTapDragZoom(InteractiveFlag.all)}');
  print('Has scroll wheel zoom: ${InteractiveFlag.hasFlag(InteractiveFlag.all, InteractiveFlag.scrollWheelZoom)}');
}

Do you have a potential solution?

Change the following line in interactive_flag.dart:

 static const int all =
      drag | flingAnimation | pinchMove | pinchZoom | doubleTapZoom | rotate;

to:

 static const int all =
      drag | flingAnimation | pinchMove | pinchZoom | doubleTapZoom |doubleTapDragZoom | scrollWheelZoom | rotate;

Platforms

Windows 11

Severity

Minimum: Allows normal functioning

@amal-stack amal-stack added bug This issue reports broken functionality or another error needs triage This new bug report needs reproducing and prioritizing labels Nov 10, 2023
@josxha josxha removed the needs triage This new bug report needs reproducing and prioritizing label Nov 23, 2023
@josxha josxha added this to the v6.1 milestone Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue reports broken functionality or another error
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants