Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag is not fluid enough #492

Closed
virshlee opened this issue Dec 27, 2019 · 8 comments · Fixed by #572
Closed

Drag is not fluid enough #492

virshlee opened this issue Dec 27, 2019 · 8 comments · Fixed by #572
Labels
feature This issue requests a new feature

Comments

@virshlee
Copy link

virshlee commented Dec 27, 2019

I compared flutter_map to the normal google maps. Don't get me wrong, flutter_map's drag works fine, but it's as not smooth as the one in google maps. Do you have any idea what's the difference?

@johnpryan johnpryan added the feature This issue requests a new feature label Jan 2, 2020
@kleeb
Copy link

kleeb commented Jan 8, 2020

Google Maps SDK has prebuilt vectorisation. Thats why this zooming in/out feels so smooth when in the meantime its downloading all relevant tiles. Not sure what would need to be done to make the UX better, maybe some rasterisation of the tiles before we get a new one from the network.

@johnpryan
Copy link
Collaborator

also related to flinging behavior: #271

@virshlee
Copy link
Author

virshlee commented Jan 9, 2020

I compared flutter_map to the normal google maps. Don't get me wrong, flutter_map's drag works fine, but it's as not smooth as the one in google maps. Do you have any idea what's the difference?

I see it even when all the needed tiles are loaded, also I checked the javascript web implementation of leaflet, and that was also smoother than the flutter version, I haven't checked the full code there though, do you have any idea about the main differences in the dragging? I think that the move method itself is the problem, as the bit jerky movement is even seen when I make an animated move to a certain location, not even dragging.

@johnpryan
Copy link
Collaborator

Right now what we have is a rough attempt to allow for two-finger dragging and zooming. Pull requests are accepted :)

@virshlee
Copy link
Author

virshlee commented Jan 11, 2020

Right now what we have is a rough attempt to allow for two-finger dragging and zooming. Pull requests are accepted :)

I will take a look at it, also it is possible that it would be better if I could run it in 60fps, I can't go above about 40 fps even in performance mode.

@virshlee
Copy link
Author

Right now what we have is a rough attempt to allow for two-finger dragging and zooming. Pull requests are accepted :)

Do you think the whole plugin could be made more fluid by multi threading some back-end work? Ex the gesture could be calculated on a different thread or isolate as it's called in flutter I think.

@MihaMarkic
Copy link

I feel that putting gesture calculation in isolate would yield worse performance. Or is that calculation that much demanding? Perhaps some perf measurement could help.

@maRci002
Copy link
Contributor

maRci002 commented Apr 6, 2020

Hi, @virshlee could please take a test ride with #572 PR, maybe it resolves this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue requests a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants