Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjoint Field projection monitor support #1114

Closed
tylerflex opened this issue Aug 29, 2023 · 3 comments · Fixed by #1822
Closed

adjoint Field projection monitor support #1114

tylerflex opened this issue Aug 29, 2023 · 3 comments · Fixed by #1822
Assignees
@yaugenst-flex
Labels
2.8 will go into version 2.8.* rc1 1st pre-release

Comments

@tylerflex
Copy link
Collaborator

No description provided.

@tylerflex tylerflex self-assigned this Aug 29, 2023
@tylerflex tylerflex changed the title Field projection monitor support adjoint Field projection monitor support Aug 29, 2023
@tylerflex
Copy link
Collaborator Author

Note: after an attempt, realized this is a huge mess unless we can get xarray wrappers working with jax.

First thing I might try is incorporating the strategy outlined in jax-ml/jax#17107 (comment)

@tylerflex
Copy link
Collaborator Author

Tried that strategy and it seems to not be the solution we need, I think the way forward is to first:

  • Implement a JaxDataset emulator for xarray.Dataset with JaxDataArray internals.
  • modify the field projection, intensity, and other things using this dataset wrapper.

@tylerflex tylerflex mentioned this issue Mar 15, 2024
Open
95 tasks
@tylerflex tylerflex removed the adjoint label May 24, 2024
@tylerflex tylerflex assigned yaugenst-flex and unassigned tylerflex Aug 2, 2024
@tylerflex
Copy link
Collaborator Author

adjoint plugin is deprecated

This will be supported natively using autograd in #1822 and will add a note for server side in the adjoint master plan #1548

@tylerflex tylerflex linked a pull request Aug 2, 2024 that will close this issue
Differentiable local field projection #1822
Merged
@yaugenst-flex yaugenst-flex mentioned this issue Sep 4, 2024
Open
11 tasks
@yaugenst-flex yaugenst-flex added rc1 1st pre-release 2.8 will go into version 2.8.* labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yaugenst-flex yaugenst-flex

Labels
2.8 will go into version 2.8.* rc1 1st pre-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Differentiable local field projection flexcompute/tidy3d
2 participants
@tylerflex @yaugenst-flex