Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISCUSSION: Should we only allow one integration instance per integration? #556

Open
dzwillia opened this issue Sep 29, 2019 · 2 comments
Open
Assignees

Comments

@dzwillia
Copy link
Member

No description provided.

@dzwillia dzwillia changed the title DISCUSSION: \] DISCUSSION: Should we only allow one integration installation per integration? Sep 29, 2019
@dzwillia dzwillia changed the title DISCUSSION: Should we only allow one integration installation per integration? DISCUSSION: Should we only allow one integration instance per integration? Sep 29, 2019
@dzwillia
Copy link
Member Author

Right now it is possible to install an integration as many times as you want. We assign new names "hubspot2", "hubspot3", etc. to each one. While this is technically possible, does it make sense?

It seems to me that, while this is possible, if you have installed the HubSpot integration, you shouldn't be able to install it again. We have the "Refresh" option if it were ever to become stale.

Seems like we may also want to re-visit the idea of whether or not these are editable by the user. This was initially brought up in issue #506.

@wanderslth
Copy link
Member

Right now it is possible to install an integration as many times as you want.

If you think you will take Aaron's triple Hubspot accounts out of his cold dead hands, you have another thing coming. :) Personally, I don't see a use case for multiple Hubspots (there will only be one with any given organization); however, Aaron's wants to keep the cross-org vision open (he and Jason), where someone is setting something up and then inviting a cross org person into to set up the same account. I don't think there is a big downside into having multiple ones; we'll have to see how it plays out in practice if anyone uses it that way.

Seems like we may also want to re-visit the idea of whether or not these are editable by the user.

I'm not sold on the mount/integration edits, but I think that when we discussed this last we were going to make a fearsome are you sure you want to refresh this mount? If so, all edits you made will go bye-bye, Please confirm by typing 'DELETE" below). The bigger issue now is how we handle the mount settings as it relates to refresh -- since the refresh shouldn't mess with the api key settings etc. Just need to make sure we have clear rules of the road with what a use can/can't do and what the fallout is if they do things like 'refresh' or 'delete'. This will also come into play on how we handle the interplay with the connections area (like we discussed last week), local nodes, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants