Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android, AndroidTV, Androidewear] dupicates of target list when device is active #1202

Closed
pauliusguzas opened this issue Oct 24, 2023 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@pauliusguzas
Copy link
Collaborator

Describe the bug
Android/AndroidTV/Androidwear shows duplicate simulators in target list if that simulator is open (sanity_1.0.0-2 tag)

To Reproduce

  1. go to template-starter package
  2. have android simulator open
  3. run rnv target list -p androidwear
pauliusguzas@MBP-de-Flexn template-starter % rnv target list -p androidwear

┌──────────────────────────────────────────────────────────────────────────────┐
│                                                                              │
│        ██████╗ ███████╗███╗   ██╗ █████╗ ████████╗██╗██╗   ██╗███████╗       │
│        ██╔══██╗██╔════╝████╗  ██║██╔══██╗╚══██╔══╝██║██║   ██║██╔════╝       │
│        ██████╔╝█████╗  ██╔██╗ ██║███████║   ██║   ██║██║   ██║█████╗         │
│        ██╔══██╗██╔══╝  ██║╚██╗██║██╔══██║   ██║   ██║╚██╗ ██╔╝██╔══╝         │
│        ██║  ██║███████╗██║ ╚████║██║  ██║   ██║   ██║ ╚████╔╝ ███████╗       │
│        ╚═╝  ╚═╝╚══════╝╚═╝  ╚═══╝╚═╝  ╚═╝   ╚═╝   ╚═╝  ╚═══╝  ╚══════╝       │
│                                                                              │
│        Version: 1.0.0-canary.7                                               │
│        https://renative.org                                                  │
│        🚀 Firing up!...                                                      │
│        $ rnv target list -p androidwear                                      │
│        Start Time: 10/24/2023, 5:40:29 PM                                    │
│                                                                              │
└──────────────────────────────────────────────────────────────────────────────┘

[ task ] registerEngine:engine-core[1]
[ task ] configureRuntimeDefaults[1] appId:undefined
[ task ] checkAndMigrateProject[1]
[ task ] loadPluginTemplates[1]
[ task ] parseRenativeConfigs[1]
[ task ] getWorkspaceDirPath[1]
[ task ] generatePlatformTemplatePaths[1]
[ task ] checkAndBootstrapIfRequired[1]
[ task ] loadIntegrations[1]
[ task ] loadEngines[1]
[ task ] loadEnginePluginDeps[1]
[ task ] loadEnginePackageDeps[1]
[ task ] registerEngine:engine-rn[1]
[ task ] findSuitableTask[1]
[ info ] Current Engine: engine-core path: undefined
[ task ] registerMissingPlatformEngines[1]
[ task ] initializeTask[1] target list
[ task ] => [target list]
[ task ] [target list] taskRnvTargetList[1]
[ task ] [target list] isPlatformSupported[1]
[ task ] [target list] checkAndConfigureSdks[1]
[ task ] [target list] checkAndConfigureAndroidSdks[1] (/Users/pauliusguzas/Library/Android/sdk)
[ task ] => [target launch] => [workspace configure]
[ task ] [workspace configure] taskRnvWorkspaceConfigure[1]
[ task ] <= [target launch] <= workspace configure
[ task ] [target launch] checkSdk[1]
[ task ] [target launch] checkAndroidSdk[1]
[ task ] [target launch] _isSdkInstalled[1]
[ task ] [target launch] checkAndConfigureAndroidSdks[2] (/Users/pauliusguzas/Library/Android/sdk)
[ task ] [target launch] listAndroidTargets[1]
[ task ] [target launch] getAndroidTargets[1] skipDevices:false skipAvds:false deviceOnly:false
✔ Executing: /Users/pauliusguzas/Library/Android/sdk/platform-tools/adb devices -l
✔ Executing: /Users/pauliusguzas/Library/Android/sdk/emulator/emulator -list-avds
✔ Waiting for emulator to boot...
✔ Waiting for emulator to boot...
✔ Executing: /Users/pauliusguzas/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell wm size
✔ Executing: /Users/pauliusguzas/Library/Android/sdk/platform-tools/adb -s emulator-5556 shell wm size
✔ Executing: /Users/pauliusguzas/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell wm density
✔ Executing: /Users/pauliusguzas/Library/Android/sdk/platform-tools/adb -s emulator-5556 shell wm density
✔ Executing: /Users/pauliusguzas/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell getprop
✔ Executing: /Users/pauliusguzas/Library/Android/sdk/platform-tools/adb -s emulator-5556 shell getprop
[ task ] [target launch] composeDevicesString[1] numDevices:2
[ task ] <= target list

 $ rnv target list -p androidwear - Done! 🚀
┌──────────────────────────────────────────────────────────────────────────────┐
│  🚀  SUMMARY | 10/24/2023, 5:40:34 PM                                        │
│  $ rnv target list -p androidwear                                            │
├──────────────────────────────────────────────────────────────────────────────┤
│  ReNative Version: 1.0.0-canary.7                                            │
│  Project Name ($package.name): @rnv/template-starter                         │
│  Project Version ($package.version): 1.0.0-canary.7                          │
│  Workspace ($.workspaceID): rnv                                              │
│  Platform (-p): androidwear                                                  │
│  Engine ($.platforms.androidwear.engine): engine-core                        │
│  App Config (-c): template                                                   │
│  Build Scheme (-s): debug                                                    │
│  Master Template: @rnv/template-starter                                      │
│  Env Info: darwin | x64 | node v18.16.0                                      │
│  Executed Time: 0h:0m:4s:528ms                                               │
│                                                                              │
│
Android Targets:

 [1]> Android_Wear_Round_API_28 | Wear ⌚  | arch: x86 | udid: emulator-5554  (active)
 [2]> Android_Wear_Round_API_28 | Wear ⌚  | arch: x86 | udid: unknown

│ You are trying to run global rnv command in your current project.
│ This might lead to unexpected behaviour.
│ Run your rnv command with npx prefix:
│ npx rnv target list -p androidwear
│                                                                              │
└──────────────────────────────────────────────────────────────────────────────┘
pauliusguzas@MBP-de-Flexn template-starter %

Expected behavior
Shows one entry instead of two

Desktop (please complete the following information):

  • OS: Ventura 13.5.2 (Intel)
  • Node Version 18.16.0
  • RNV Version 1.0.0-canary.7
  • rnv/template-starter Version 1.0.0-canary.7
@pauliusguzas pauliusguzas added the bug Something isn't working label Oct 24, 2023
@pavjacko pavjacko added this to the 1.0 milestone Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants